You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/22 10:13:30 UTC

[GitHub] [apisix-ingress-controller] lingsamuel edited a comment on issue #879: Makefile: add `update-` for `verify-`

lingsamuel edited a comment on issue #879:
URL: https://github.com/apache/apisix-ingress-controller/issues/879#issuecomment-1047626902


   `goimports-reviser` can sort project packages as a separate group, e.g.:
   
   ```
   package testdata
   
   import (
   	"bytes"
   	"log"
   	
   	"github.com/abcabc/abcabc"
   	"github.com/pkg/errors"
   	
   	"github.com/incu6us/goimports-reviser/testdata/innderpkg"
   )
   ```
   
   instead of 
   
   ```
   
   package testdata
   
   import (
   	"bytes"
   	"log"
   	
   	"github.com/abcabc/abcabc"
   	"github.com/incu6us/goimports-reviser/testdata/innderpkg"
   	"github.com/pkg/errors"
   )
   ```
   
   IIRC `gofmt` or `goimports` can't do this.
   
   And they seems to cannot handle this case:
   ```
   	"bytes"
   	"github.com/abcabc/abcabc"
   	"time"
   	
   	"github.com/incu6us/goimports-reviser/testdata/innderpkg"
   	"github.com/pkg/errors"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org