You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/22 09:16:00 UTC

[GitHub] [doris] xinyiZzz opened a new pull request, #11125: [fix] (mem tracker) Fix load channel mgr frequently flush mem table

xinyiZzz opened a new pull request, #11125:
URL: https://github.com/apache/doris/pull/11125

   # Proposed changes
   
   Issue Number: close #11124
   
   ## Problem Summary:
   
   1. Disable the load channel mem tracker, which will not effectively limit the memory of the load channel mgr. In order to avoid frequent flush mem table due to inaccurate statistics of load channel mem tracker.
   
   2. Modify the return value of `MemTracker::check_limit`, which will cause the schema change to fail
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes)
   2. Has unit tests been added: (No Need)
   3. Has document been added or modified: (No Need)
   4. Does it need to update dependencies: (No)
   5. Are there any changes that cannot be rolled back: (No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #11125: [fix] (mem tracker) Fix load channel mgr frequently flush mem table

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11125:
URL: https://github.com/apache/doris/pull/11125#issuecomment-1192502049

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] xinyiZzz commented on pull request #11125: [fix] (mem tracker) Fix load channel mgr frequently flush mem table

Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on PR #11125:
URL: https://github.com/apache/doris/pull/11125#issuecomment-1192424992

   > This is just a temp fix, to not check mem limit in load channel.
   > We should fix that part later.
   
   ok i will do it soon~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #11125: [fix] (mem tracker) Fix load channel mgr frequently flush mem table

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11125:
URL: https://github.com/apache/doris/pull/11125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #11125: [fix] (mem tracker) Fix load channel mgr frequently flush mem table

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11125:
URL: https://github.com/apache/doris/pull/11125#issuecomment-1192502090

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org