[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #957: MINIFICPP-1407 - Fetch flow configuration file from C2 if not found locally

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #957:
URL: https://github.com/apache/nifi-minifi-cpp/pull/957#discussion_r551953686



##########
File path: libminifi/include/core/controller/ForwardingControllerServiceProvider.h
##########
@@ -0,0 +1,136 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <memory>
+#include <vector>
+#include <string>
+
+#include "ControllerServiceProvider.h"
+#include "ControllerServiceNode.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace core {
+namespace controller {
+
+class ForwardingControllerServiceProvider : public ControllerServiceProvider {

Review comment:
       Please note that the pointer was present in the old `FlowController.h:343` and the members at old `FlowController.cpp:363-522`.
   
   I wouldn't support introducing a pimpl here, but I support the extraction of this existing pimpl to its own class, because it means one less responsibility for the bloated `FlowController` and because it's a meaningful class on its own.
   
   I also support eliminating it altogether, but it might require more changes and I don't think it's a good idea to further inflate this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org