You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/12/09 02:21:26 UTC
[GitHub] [helix] jiajunwang opened a new pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
jiajunwang opened a new pull request #1920:
URL: https://github.com/apache/helix/pull/1920
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
-
Resolves #1919
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
Add TestHelixTaskExecutor.testHandlerResetTimeout() to cover the new changes.
Also refactoring the related code to reduce duplicate and confusing code.
### Tests
- [X] The following tests are written for this issue:
TestHelixTaskExecutor.testHandlerResetTimeout()
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on a change in pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on a change in pull request #1920:
URL: https://github.com/apache/helix/pull/1920#discussion_r767018019
##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -99,14 +100,23 @@ public MsgHandlerFactoryRegistryItem(MessageHandlerFactory factory, int threadPo
throw new IllegalArgumentException("Illegal thread pool size: " + threadPoolSize);
}
+ if (resetTimeout <= 0) {
Review comment:
Nit: 0 probably should be allowed. If 0 is not allowed, why is 1 (or other small numbers) allowed?
##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -622,7 +645,8 @@ void unregisterMessageHandlerFactory(String type) {
+ ", pool: " + pool);
if (pool != null) {
- shutdownAndAwaitTermination(pool);
+ int timeout = item == null? DEFAULT_MSG_HANDLER_RESET_TIMEOUT_MS : item.getResetTimeout();
+ shutdownAndAwaitTermination(pool, timeout);
Review comment:
Nit: consider moving line 648 into shutdownAndAwaitTermination to avoid repeating it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1920:
URL: https://github.com/apache/helix/pull/1920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1920:
URL: https://github.com/apache/helix/pull/1920#discussion_r768088199
##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -622,7 +645,8 @@ void unregisterMessageHandlerFactory(String type) {
+ ", pool: " + pool);
if (pool != null) {
- shutdownAndAwaitTermination(pool);
+ int timeout = item == null? DEFAULT_MSG_HANDLER_RESET_TIMEOUT_MS : item.getResetTimeout();
+ shutdownAndAwaitTermination(pool, timeout);
Review comment:
Good point. Will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1920:
URL: https://github.com/apache/helix/pull/1920#discussion_r768090158
##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -225,14 +249,12 @@ public void registerMessageHandlerFactory(String type, MessageHandlerFactory fac
_monitor.createExecutorMonitor(type, newPool);
return newPool;
});
- LOG.info(
- "Registered message handler factory for type: " + type + ", poolSize: " + threadpoolSize
- + ", factory: " + factory + ", pool: " + _executorMap.get(type));
+ LOG.info("Registered message handler factory for type: " + type + ", poolSize: " + threadpoolSize + ", factory: "
Review comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1920:
URL: https://github.com/apache/helix/pull/1920#issuecomment-993052595
Approved by @NealSun96 , all comments have been addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a change in pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on a change in pull request #1920:
URL: https://github.com/apache/helix/pull/1920#discussion_r767021180
##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -225,14 +249,12 @@ public void registerMessageHandlerFactory(String type, MessageHandlerFactory fac
_monitor.createExecutorMonitor(type, newPool);
return newPool;
});
- LOG.info(
- "Registered message handler factory for type: " + type + ", poolSize: " + threadpoolSize
- + ", factory: " + factory + ", pool: " + _executorMap.get(type));
+ LOG.info("Registered message handler factory for type: " + type + ", poolSize: " + threadpoolSize + ", factory: "
Review comment:
nit: I would suggest using [parameterized logging](http://www.slf4j.org/faq.html#logging_performance). String + String adds a lot cost when constructing the message parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a change in pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on a change in pull request #1920:
URL: https://github.com/apache/helix/pull/1920#discussion_r767021180
##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -225,14 +249,12 @@ public void registerMessageHandlerFactory(String type, MessageHandlerFactory fac
_monitor.createExecutorMonitor(type, newPool);
return newPool;
});
- LOG.info(
- "Registered message handler factory for type: " + type + ", poolSize: " + threadpoolSize
- + ", factory: " + factory + ", pool: " + _executorMap.get(type));
+ LOG.info("Registered message handler factory for type: " + type + ", poolSize: " + threadpoolSize + ", factory: "
Review comment:
nit: I would suggest using [parameterized logging](http://www.slf4j.org/faq.html#logging_performance). String + String adds a lot cost when constructing the message parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1920:
URL: https://github.com/apache/helix/pull/1920#discussion_r768088721
##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -99,14 +100,23 @@ public MsgHandlerFactoryRegistryItem(MessageHandlerFactory factory, int threadPo
throw new IllegalArgumentException("Illegal thread pool size: " + threadPoolSize);
}
+ if (resetTimeout <= 0) {
Review comment:
Agreed. Will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on a change in pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on a change in pull request #1920:
URL: https://github.com/apache/helix/pull/1920#discussion_r767018019
##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -99,14 +100,23 @@ public MsgHandlerFactoryRegistryItem(MessageHandlerFactory factory, int threadPo
throw new IllegalArgumentException("Illegal thread pool size: " + threadPoolSize);
}
+ if (resetTimeout <= 0) {
Review comment:
Nit: 0 probably should be allowed. If 0 is not allowed, why is 1 (or other small numbers) allowed?
##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -622,7 +645,8 @@ void unregisterMessageHandlerFactory(String type) {
+ ", pool: " + pool);
if (pool != null) {
- shutdownAndAwaitTermination(pool);
+ int timeout = item == null? DEFAULT_MSG_HANDLER_RESET_TIMEOUT_MS : item.getResetTimeout();
+ shutdownAndAwaitTermination(pool, timeout);
Review comment:
Nit: consider moving line 648 into shutdownAndAwaitTermination to avoid repeating it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org