You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/03 04:17:14 UTC
[GitHub] [kafka] ableegoldman opened a new pull request #10251: MINOR: add missing docs for record-e2e-latency metrics
ableegoldman opened a new pull request #10251:
URL: https://github.com/apache/kafka/pull/10251
I missed updating the documentation for these metrics since I didn't notice we had Streams metrics docs outside of the usual Streams docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10251: MINOR: add missing docs for record-e2e-latency metrics
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10251:
URL: https://github.com/apache/kafka/pull/10251#issuecomment-790226079
Call for review also any of @lct45 @wcarlson5 @swist @mjsax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10251: MINOR: add missing docs for record-e2e-latency metrics
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10251:
URL: https://github.com/apache/kafka/pull/10251#issuecomment-790998614
Merged to trunk and cherrypicked to 2.7 and 2.8 (cc @vvcephei , it's docs only)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10251: MINOR: add missing docs for record-e2e-latency metrics
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #10251:
URL: https://github.com/apache/kafka/pull/10251#discussion_r586100402
##########
File path: docs/ops.html
##########
@@ -2356,6 +2356,26 @@ <h5 class="anchor-heading"><a id="kafka_streams_task_monitoring" class="anchor-l
<td>The total number of records dropped within this task.</td>
<td>kafka.streams:type=stream-task-metrics,thread-id=([-.\w]+),task-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>active-process-ratio</td>
Review comment:
Noticed that we seem to be missing this task-level metric as well. Might be good to take stock of all the metrics at some point and make sure they're documented clearly, especially since it's easy to miss this doc which is outside of the usual Streams docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #10251: MINOR: add missing docs for record-e2e-latency metrics
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10251:
URL: https://github.com/apache/kafka/pull/10251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10251: MINOR: add missing docs for record-e2e-latency metrics
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10251:
URL: https://github.com/apache/kafka/pull/10251#issuecomment-790997202
Looks like all three Java builds passed, but some of the other builds failed (with timeout I believe). This is a docs-only change anyway so I think it's safe to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10251: MINOR: add missing docs for record-e2e-latency metrics
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10251:
URL: https://github.com/apache/kafka/pull/10251#issuecomment-789415834
call for review @cadonna @vvcephei @guozhangwang -- in theory we should cherrypick this back to 2.8 at least, but I can prepare a separate PR against `kafka-site` if we don't get this merged in time (not worth blocking 2.8 over obviously)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org