You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/01/30 23:01:34 UTC
[jira] Created: (CASSANDRA-751) refactor streaming
refactor streaming
------------------
Key: CASSANDRA-751
URL: https://issues.apache.org/jira/browse/CASSANDRA-751
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 0.6
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-751) refactor streaming
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806761#action_12806761 ]
Jonathan Ellis commented on CASSANDRA-751:
------------------------------------------
committed:
1. should be fixed on commit, i run my ide from windows so the diffs will have \r\n in them if i understand how svn line munging works
2. moved to StorageService. All Hail the Big Central Singleton :)
3. changed to PendingFile
4. moved to streaming package; haven't renamed things because StreamInitiateMessage corresponds to STREAM_INITIATE verb
5. done
> refactor streaming
> ------------------
>
> Key: CASSANDRA-751
> URL: https://issues.apache.org/jira/browse/CASSANDRA-751
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-centralize-streaming-code-in-org.apache.cassandra.stre.txt, 0002-split-Streaming-into-StreamOut-and-StreamIn-clean-up-S.txt, 0003-rename-StreamContextManager-StreamInManager-StreamMang.txt, 0004-r-m-unneeded-StreamStatusMessage-wrapper.txt, 0005-extract-SIM.StreamStatus-to-CompletedFileStatus.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-751) refactor streaming
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806747#action_12806747 ]
Jonathan Ellis commented on CASSANDRA-751:
------------------------------------------
05
extract SIM.StreamStatus to CompletedFileStatus
04
r/m unneeded StreamStatusMessage wrapper
03
rename StreamContextManager -> StreamInManager, StreamManger -> StreamOutManager, extract SCM.StreamContext -> InitiatedFile
02
split Streaming into StreamOut and StreamIn; clean up StreamManager
01
centralize streaming code in org.apache.cassandra.streaming; split out verbs & handlers into top-level classes
> refactor streaming
> ------------------
>
> Key: CASSANDRA-751
> URL: https://issues.apache.org/jira/browse/CASSANDRA-751
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-centralize-streaming-code-in-org.apache.cassandra.stre.txt, 0002-split-Streaming-into-StreamOut-and-StreamIn-clean-up-S.txt, 0003-rename-StreamContextManager-StreamInManager-StreamMang.txt, 0004-r-m-unneeded-StreamStatusMessage-wrapper.txt, 0005-extract-SIM.StreamStatus-to-CompletedFileStatus.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-751) refactor streaming
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-751:
-------------------------------------
Attachment: 0005-extract-SIM.StreamStatus-to-CompletedFileStatus.txt
0004-r-m-unneeded-StreamStatusMessage-wrapper.txt
0003-rename-StreamContextManager-StreamInManager-StreamMang.txt
0002-split-Streaming-into-StreamOut-and-StreamIn-clean-up-S.txt
0001-centralize-streaming-code-in-org.apache.cassandra.stre.txt
> refactor streaming
> ------------------
>
> Key: CASSANDRA-751
> URL: https://issues.apache.org/jira/browse/CASSANDRA-751
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-centralize-streaming-code-in-org.apache.cassandra.stre.txt, 0002-split-Streaming-into-StreamOut-and-StreamIn-clean-up-S.txt, 0003-rename-StreamContextManager-StreamInManager-StreamMang.txt, 0004-r-m-unneeded-StreamStatusMessage-wrapper.txt, 0005-extract-SIM.StreamStatus-to-CompletedFileStatus.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-751) refactor streaming
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806757#action_12806757 ]
Stu Hood commented on CASSANDRA-751:
------------------------------------
But even without those suggestions, this gets a +1
> refactor streaming
> ------------------
>
> Key: CASSANDRA-751
> URL: https://issues.apache.org/jira/browse/CASSANDRA-751
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-centralize-streaming-code-in-org.apache.cassandra.stre.txt, 0002-split-Streaming-into-StreamOut-and-StreamIn-clean-up-S.txt, 0003-rename-StreamContextManager-StreamInManager-StreamMang.txt, 0004-r-m-unneeded-StreamStatusMessage-wrapper.txt, 0005-extract-SIM.StreamStatus-to-CompletedFileStatus.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-751) refactor streaming
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806755#action_12806755 ]
Stu Hood commented on CASSANDRA-751:
------------------------------------
This is a huge improvement... the 'streaming' package is much more autonomous now.
1. This seems like a good opportunity to fix the line endings in all the files that moved: lots of carriage returns scattered about
2. StreamOut.RING_DELAY should move elsewhere
3. InitiatedFile isn't sticking with me... the transfer hasn't always been initialized when that object is used
4. dht.StreamInitiateMessage escaped the migration. Perhaps -> streaming.InitiateMessage
5. Since streaming is so well encapsulated now, we could probably enforce it by making a bunch of its classes package-protected: all of Stream(Out|In)Manager,Stream*(Verb|Message) for instance. The only public interfaces need to be StreamIn and StreamOut.
Thanks a bunch!
> refactor streaming
> ------------------
>
> Key: CASSANDRA-751
> URL: https://issues.apache.org/jira/browse/CASSANDRA-751
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-centralize-streaming-code-in-org.apache.cassandra.stre.txt, 0002-split-Streaming-into-StreamOut-and-StreamIn-clean-up-S.txt, 0003-rename-StreamContextManager-StreamInManager-StreamMang.txt, 0004-r-m-unneeded-StreamStatusMessage-wrapper.txt, 0005-extract-SIM.StreamStatus-to-CompletedFileStatus.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-751) refactor streaming
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood resolved CASSANDRA-751.
--------------------------------
Resolution: Fixed
> refactor streaming
> ------------------
>
> Key: CASSANDRA-751
> URL: https://issues.apache.org/jira/browse/CASSANDRA-751
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-centralize-streaming-code-in-org.apache.cassandra.stre.txt, 0002-split-Streaming-into-StreamOut-and-StreamIn-clean-up-S.txt, 0003-rename-StreamContextManager-StreamInManager-StreamMang.txt, 0004-r-m-unneeded-StreamStatusMessage-wrapper.txt, 0005-extract-SIM.StreamStatus-to-CompletedFileStatus.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-751) refactor streaming
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834861#action_12834861 ]
Hudson commented on CASSANDRA-751:
----------------------------------
Integrated in Cassandra #357 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/357/])
> refactor streaming
> ------------------
>
> Key: CASSANDRA-751
> URL: https://issues.apache.org/jira/browse/CASSANDRA-751
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 0001-centralize-streaming-code-in-org.apache.cassandra.stre.txt, 0002-split-Streaming-into-StreamOut-and-StreamIn-clean-up-S.txt, 0003-rename-StreamContextManager-StreamInManager-StreamMang.txt, 0004-r-m-unneeded-StreamStatusMessage-wrapper.txt, 0005-extract-SIM.StreamStatus-to-CompletedFileStatus.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.