[jira] [Commented] (CASSANDRA-18023) Add option to print level with getsstables output

["Cheng Wang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-18023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631315#comment-17631315 ] 

Cheng Wang commented on CASSANDRA-18023:
----------------------------------------

+1. LGTM. 

The only comment is in

src/java/org/apache/cassandra/db/compaction/CompactionStrategyManager.java
public synchronized boolean isLeveledCompaction()
I might be better to use the readLock instead of the synchronized method to be consistent with rest of the file, and to have better performance because you can have multiple concurrent threads holding the read lock?  
 

> Add option to print level with getsstables output
> -------------------------------------------------
>
>                 Key: CASSANDRA-18023
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18023
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/nodetool
>            Reporter: Jordan West
>            Assignee: Jordan West
>            Priority: Normal
>
> A common operation is to pipe getsstables output to sstablemetadata to determine the level. This adds friction to operations. Add an optional flag to getsstables to print the level with data file path. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org