You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by dp...@apache.org on 2023/06/12 12:08:06 UTC

[superset] branch master updated: chore: remove deprecated api /superset/datasources (#24333)

This is an automated email from the ASF dual-hosted git repository.

dpgaspar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 3d9c7d4598 chore: remove deprecated api /superset/datasources (#24333)
3d9c7d4598 is described below

commit 3d9c7d4598089f24b288a9ea8fed601ee355169c
Author: Daniel Vaz Gaspar <da...@gmail.com>
AuthorDate: Mon Jun 12 13:07:56 2023 +0100

    chore: remove deprecated api /superset/datasources (#24333)
---
 RESOURCES/STANDARD_ROLES.md |  1 -
 UPDATING.md                 |  1 +
 superset/views/core.py      | 16 ----------------
 3 files changed, 1 insertion(+), 17 deletions(-)

diff --git a/RESOURCES/STANDARD_ROLES.md b/RESOURCES/STANDARD_ROLES.md
index 6f70620c7d..5bb3047c0f 100644
--- a/RESOURCES/STANDARD_ROLES.md
+++ b/RESOURCES/STANDARD_ROLES.md
@@ -72,7 +72,6 @@
 |can copy dash on Superset|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
 |can publish on Superset|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
 |can csv on Superset|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|
-|can datasources on Superset|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
 |can fave dashboards by username on Superset|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
 |can sql json on Superset|:heavy_check_mark:|O|O|:heavy_check_mark:|
 |can slice on Superset|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
diff --git a/UPDATING.md b/UPDATING.md
index fb4851081c..9201886bf9 100644
--- a/UPDATING.md
+++ b/UPDATING.md
@@ -33,6 +33,7 @@ assists people when migrating to a new version.
 
 ### Breaking Changes
 
+- [24333](https://github.com/apache/superset/pull/24333): Removed deprecated API `/superset/datasources`
 - [24266](https://github.com/apache/superset/pull/24266) Remove the `ENABLE_ACCESS_REQUEST` config parameter and the associated request/approval workflows.
 - [24330](https://github.com/apache/superset/pull/24330) Removes `getUiOverrideRegistry` from `ExtensionsRegistry`.
 - [23933](https://github.com/apache/superset/pull/23933) Removes the deprecated Multiple Line Charts.
diff --git a/superset/views/core.py b/superset/views/core.py
index 61f70434fe..cc64dd23ff 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -208,22 +208,6 @@ class Superset(BaseSupersetView):  # pylint: disable=too-many-public-methods
 
     logger = logging.getLogger(__name__)
 
-    @has_access_api
-    @event_logger.log_this
-    @expose("/datasources/")
-    @deprecated(new_target="api/v1/dataset/")
-    def datasources(self) -> FlaskResponse:
-        return self.json_response(
-            sorted(
-                [
-                    datasource.short_data
-                    for datasource in security_manager.get_user_datasources()
-                    if datasource.short_data.get("name")
-                ],
-                key=lambda datasource: datasource["name"],
-            )
-        )
-
     @has_access
     @event_logger.log_this
     @expose("/slice/<int:slice_id>/")