You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/04/29 14:45:10 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3850: [ISSUE #3849]GrpcMessageProtocolResolver has many unused variables and repetitive method def.
pandaapo opened a new pull request, #3850:
URL: https://github.com/apache/eventmesh/pull/3850
Fixes #3849.
Fixes #3839
### Motivation
org.apache.eventmesh.protocol.cloudevents.resolver.grpc.GrpcMessageProtocolResolver:
Many unused variable in `buildBatchEvents()`.
`getMessageItemValue()` and `getHeaderValue()` have the same body.
Some logic ignore the existing api.
And so on.
### Modifications
Remove unused variables and repetitive method. Use existing api. And other modifications.
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3850: [ISSUE #3849]GrpcMessageProtocolResolver has many unused variables and repetitive method def.
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3850:
URL: https://github.com/apache/eventmesh/pull/3850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] yelbom commented on pull request #3850: [ISSUE #3849]GrpcMessageProtocolResolver has many unused variables and repetitive method def.
Posted by "yelbom (via GitHub)" <gi...@apache.org>.
yelbom commented on PR #3850:
URL: https://github.com/apache/eventmesh/pull/3850#issuecomment-1528810675
My desktop won't connect to my modem/hotspot s🤨
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3850: [ISSUE #3849]GrpcMessageProtocolResolver has many unused variables and repetitive method def.
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3850:
URL: https://github.com/apache/eventmesh/pull/3850#issuecomment-1529238073
> My desktop won't connect to my modem/hotspot s🤨
The community welcomes discussions, questions, contributions, and other technical related content, but please do not post such comments that have no meaning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3850: [ISSUE #3849]GrpcMessageProtocolResolver has many unused variables and repetitive method def.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3850:
URL: https://github.com/apache/eventmesh/pull/3850#issuecomment-1535836188
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3850](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c254b93) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/91aab4d4ec18b7644c45e745fc85aafd053d8fd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91aab4d) will **increase** coverage by `0.01%`.
> The diff coverage is `14.28%`.
> :exclamation: Current head c254b93 differs from pull request most recent head 149b297. Consider uploading reports for the commit 149b297 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3850 +/- ##
============================================
+ Coverage 13.77% 13.78% +0.01%
Complexity 1290 1290
============================================
Files 571 571
Lines 29129 29091 -38
Branches 2837 2832 -5
============================================
- Hits 4012 4011 -1
+ Misses 24745 24708 -37
Partials 372 372
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...olver/http/SendMessageBatchV2ProtocolResolver.java](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9yZXNvbHZlci9odHRwL1NlbmRNZXNzYWdlQmF0Y2hWMlByb3RvY29sUmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...olver/http/SendMessageRequestProtocolResolver.java](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9yZXNvbHZlci9odHRwL1NlbmRNZXNzYWdlUmVxdWVzdFByb3RvY29sUmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...mesh/storage/kafka/consumer/KafkaConsumerImpl.java](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvc3RvcmFnZS9rYWZrYS9jb25zdW1lci9LYWZrYUNvbnN1bWVySW1wbC5qYXZh) | `9.09% <ø> (ø)` | |
| [.../knative/cloudevent/impl/KnativeMessageWriter.java](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLWtuYXRpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL2tuYXRpdmUvY2xvdWRldmVudC9pbXBsL0tuYXRpdmVNZXNzYWdlV3JpdGVyLmphdmE=) | `61.11% <0.00%> (ø)` | |
| [...eventmesh/storage/pravega/PravegaConsumerImpl.java](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXByYXZlZ2Evc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3ByYXZlZ2EvUHJhdmVnYUNvbnN1bWVySW1wbC5qYXZh) | `16.66% <ø> (ø)` | |
| [...torage/pravega/client/PravegaCloudEventWriter.java](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXByYXZlZ2Evc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3ByYXZlZ2EvY2xpZW50L1ByYXZlZ2FDbG91ZEV2ZW50V3JpdGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...standalone/consumer/StandaloneConsumerAdaptor.java](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXN0YW5kYWxvbmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZUNvbnN1bWVyQWRhcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/eventmesh/trace/jaeger/JaegerTraceService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtamFlZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2UvamFlZ2VyL0phZWdlclRyYWNlU2VydmljZS5qYXZh) | `60.00% <ø> (ø)` | |
| [...eventmesh/trace/pinpoint/PinpointTraceService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtcGlucG9pbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC90cmFjZS9waW5wb2ludC9QaW5wb2ludFRyYWNlU2VydmljZS5qYXZh) | `52.17% <ø> (ø)` | |
| [...che/eventmesh/trace/zipkin/ZipkinTraceService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2Utemlwa2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2Uvemlwa2luL1ppcGtpblRyYWNlU2VydmljZS5qYXZh) | `55.12% <ø> (ø)` | |
| ... and [2 more](https://app.codecov.io/gh/apache/eventmesh/pull/3850?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org