You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by pr...@apache.org on 2016/04/21 22:46:29 UTC
hive git commit: HIVE-13487: Finish time is wrong when perflog is
missing SUBMIT_TO_RUNNING (Prasanth Jayachandran reviewed by Sergey
Shelukhin)
Repository: hive
Updated Branches:
refs/heads/master 9b5eb45b8 -> 1ec276fdb
HIVE-13487: Finish time is wrong when perflog is missing SUBMIT_TO_RUNNING (Prasanth Jayachandran reviewed by Sergey Shelukhin)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/1ec276fd
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/1ec276fd
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/1ec276fd
Branch: refs/heads/master
Commit: 1ec276fdb7ba5ae82cef3bf783f8ae0765b73aeb
Parents: 9b5eb45
Author: Prasanth Jayachandran <pr...@apache.org>
Authored: Thu Apr 21 15:45:51 2016 -0500
Committer: Prasanth Jayachandran <pr...@apache.org>
Committed: Thu Apr 21 15:45:51 2016 -0500
----------------------------------------------------------------------
.../hadoop/hive/ql/exec/tez/TezJobMonitor.java | 21 ++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/1ec276fd/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java b/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java
index 7a7e2ac..0c635b2 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java
@@ -225,7 +225,7 @@ public class TezJobMonitor {
long startTime = 0;
boolean isProfileEnabled = HiveConf.getBoolVar(conf, HiveConf.ConfVars.TEZ_EXEC_SUMMARY) ||
Utilities.isPerfOrAboveLogging(conf);
- boolean llapIoEnabled = HiveConf.getBoolVar(conf, HiveConf.ConfVars.LLAP_IO_ENABLED, true);
+ boolean llapIoEnabled = HiveConf.getBoolVar(conf, HiveConf.ConfVars.LLAP_IO_ENABLED, false);
boolean inPlaceEligible = InPlaceUpdates.inPlaceEligible(conf);
synchronized(shutdownList) {
@@ -357,7 +357,7 @@ public class TezJobMonitor {
double duration = (System.currentTimeMillis() - startTime) / 1000.0;
console.printInfo("Status: DAG finished successfully in "
+ String.format("%.2f seconds", duration));
- console.printInfo("\n");
+ console.printInfo("");
console.printInfo(QUERY_EXEC_SUMMARY_HEADER);
printQueryExecutionBreakDown();
@@ -367,15 +367,15 @@ public class TezJobMonitor {
console.printInfo(TASK_SUMMARY_HEADER);
printDagSummary(progressMap, console, dagClient, conf, dag);
console.printInfo(SEPARATOR);
- console.printInfo("");
if (llapIoEnabled) {
+ console.printInfo("");
console.printInfo(LLAP_IO_SUMMARY_HEADER);
printLlapIOSummary(progressMap, console, dagClient);
console.printInfo(SEPARATOR);
}
- console.printInfo("\n");
+ console.printInfo("");
}
return rc;
@@ -445,13 +445,18 @@ public class TezJobMonitor {
// accept to start dag (schedule wait time, resource wait time etc.)
long acceptToStart = perfLogger.getDuration(PerfLogger.TEZ_SUBMIT_TO_RUNNING);
- console.printInfo(String.format(OPERATION_SUMMARY, "Start",
+ console.printInfo(String.format(OPERATION_SUMMARY, "Start DAG",
secondsFormat.format(acceptToStart / 1000.0) + "s"));
// time to actually run the dag (actual dag runtime)
- long startToEnd = perfLogger.getEndTime(PerfLogger.TEZ_RUN_DAG) -
- perfLogger.getEndTime(PerfLogger.TEZ_SUBMIT_TO_RUNNING);
- console.printInfo(String.format(OPERATION_SUMMARY, "Finish",
+ final long startToEnd;
+ if (acceptToStart == 0) {
+ startToEnd = perfLogger.getDuration(PerfLogger.TEZ_RUN_DAG);
+ } else {
+ startToEnd = perfLogger.getEndTime(PerfLogger.TEZ_RUN_DAG) -
+ perfLogger.getEndTime(PerfLogger.TEZ_SUBMIT_TO_RUNNING);
+ }
+ console.printInfo(String.format(OPERATION_SUMMARY, "Run DAG",
secondsFormat.format(startToEnd / 1000.0) + "s"));
}