You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/07/23 04:05:07 UTC

[Bug 120344] New: The line spacing of the paragraphs is incorrectly if open the .ppt doc

https://issues.apache.org/ooo/show_bug.cgi?id=120344

          Priority: P3
            Bug ID: 120344
          Assignee: ooo-issues@incubator.apache.org
           Summary: The line spacing of the paragraphs is incorrectly if
                    open the .ppt doc
          Severity: normal
        Issue Type: DEFECT
    Classification: Application
                OS: All
          Reporter: jiazema@gmail.com
          Hardware: All
            Status: UNCONFIRMED
           Version: AOO350-dev
         Component: ui
           Product: presentation

Created attachment 78702
  --> https://issues.apache.org/ooo/attachment.cgi?id=78702&action=edit
sample file

1. Open the sample file with AOO
2. The line space between text is changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120344] The line spacing of the paragraphs is incorrectly if open the .ppt doc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120344

WangZhe <ki...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kingwisemmx@gmail.com
           Assignee|ooo-issues@incubator.apache |kingwisemmx@gmail.com
                   |.org                        |

--- Comment #10 from WangZhe <ki...@gmail.com> ---
I'll take this one

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120344] The line spacing of the paragraphs is incorrectly if open the .ppt doc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120344

--- Comment #9 from Ma Bingbing <ji...@gmail.com> ---
@Andre: I check the patch on version 1367879, full build, then build the module
editeng and filter as debug mode, the code can be reached and the patch works.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120344] The line spacing of the paragraphs is incorrectly if open the .ppt doc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120344

Andre <aw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |awf.aoo@googlemail.com

--- Comment #5 from Andre <aw...@googlemail.com> ---
@Ma Bingbing: I have the same question as Regina, why only fix the symptoms and
not the root cause?  How much more work would that be?

Can you explain your fix a little bit more to make the review easier?


Just for your convenience, the links to the issues mentioned above are bug
15927 and bug 16345 (Apache Bugzilla only recognizes an issue id when prefixed
with the word "bug").

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120344] The line spacing of the paragraphs is incorrectly if open the .ppt doc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120344

Li Feng Wang <ph...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |phoenix.wanglf@gmail.com
     Ever confirmed|0                           |1

--- Comment #1 from Li Feng Wang <ph...@gmail.com> ---
Can reproduce with AOO trunk r1362376 on Windows XP.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120344] The line spacing of the paragraphs is incorrectly if open the .ppt doc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120344

--- Comment #6 from Ma Bingbing <ji...@gmail.com> ---
The reason of this patch is that somebody may meet the same issue, and they can
use this function normally before fully implementing the property value
"fixed".
(bug 15927 and bug 16345 were created several years, but not make headway now)

Moreover, I will spend time to research and resolve this problem, but I don't
know how much i need. Thanks for your sharing knowledge which let me know more
details about the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120344] The line spacing of the paragraphs is incorrectly if open the .ppt doc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120344

--- Comment #4 from Regina Henschel <rb...@t-online.de> ---
If I understand it right, you do not fully implement the property value
"fixed". Why not?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120344] The line spacing of the paragraphs is incorrectly if open the .ppt doc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120344

--- Comment #7 from Andre <aw...@googlemail.com> ---
I have tested the patch but the code is never reached (with the test document).

@Ma Bingbing: Can you check that the attached test document and patch work on
your side?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120344] The line spacing of the paragraphs is incorrectly if open the .ppt doc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120344

--- Comment #8 from Ma Bingbing <ji...@gmail.com> ---
I had checked it before I submitted this patch, and I also ask someone to
verify it. I will re-check it on latest version, but AOO build has build break
now, so I will do that later.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120344] The line spacing of the paragraphs is incorrectly if open the .ppt doc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120344

Ma Bingbing <ji...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78711|                            |review?
              Flags|                            |

--- Comment #3 from Ma Bingbing <ji...@gmail.com> ---
Created attachment 78711
  --> https://issues.apache.org/ooo/attachment.cgi?id=78711&action=edit
Fix patch for this issue

when the line space is "fixed", we should reset the text height and max ascent
of the line.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120344] The line spacing of the paragraphs is incorrectly if open the .ppt doc

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120344

Regina Henschel <rb...@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rb.henschel@t-online.de

--- Comment #2 from Regina Henschel <rb...@t-online.de> ---
The line spacing is set to fixed in Powerpoint, but the value "fixed" does not
exist in Impress but only for Writer and Writer-frames, but not for shapes or
textboxes.
The surrogate "at least" uses the maximum of font size and given value. So here
the font size is 18pt and the value is 10pt, so line space 18pt is used.

Issue 15927 tells, that line space "fixed" has been added, but I still do not
see it.

This is not specific for presentation, but a general missing feature or bug in
the edit engine. The feature request for it is already in issue 16345.

-- 
You are receiving this mail because:
You are the assignee for the bug.