You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2014/05/19 17:37:39 UTC

[jira] [Commented] (SOLR-5834) Overseer threads are only being interrupted and not closed.

    [ https://issues.apache.org/jira/browse/SOLR-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001898#comment-14001898 ] 

Shalin Shekhar Mangar commented on SOLR-5834:
---------------------------------------------

[~markrmiller@gmail.com] - You remove volatile from the definition of OverseerCollectionProcessor.isClosed. Was that deliberate? I read the discussion on SOLR-5823 but couldn't figure out why that was necessary.

> Overseer threads are only being interrupted and not closed.
> -----------------------------------------------------------
>
>                 Key: SOLR-5834
>                 URL: https://issues.apache.org/jira/browse/SOLR-5834
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.7.1, 4.8, 5.0
>
>
> As noticed by Hossman in SOLR-5823, the Overseer is not actually calling close on the runnables that are used to create threads - the treads are only being interrupted in Overseer#close, but not closed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org