You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2015/06/04 14:07:35 UTC
Re: Review Request 35061: [FALCON-1254] ClusterSetup UI: edit xml
test cases, fix testLocationsBadPermissions, testDefaultScenario
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35061/
-----------------------------------------------------------
(Updated June 4, 2015, 12:07 p.m.)
Review request for Falcon.
Changes
-------
adding fix for testDefaultScenario
Summary (updated)
-----------------
[FALCON-1254] ClusterSetup UI: edit xml test cases, fix testLocationsBadPermissions, testDefaultScenario
Bugs: FALCON-1254
https://issues.apache.org/jira/browse/FALCON-1254
Repository: falcon-git
Description (updated)
-------
Adding testEditXml, testEditXmlInvalidValues. Fix testLocationsBadPermissions (alert message), testDefaultScenario (extra step while parsing properties).
Diffs (updated)
-----
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 92b1ee5
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java d616b84
Diff: https://reviews.apache.org/r/35061/diff/
Testing
-------
checkstyle passed
testEditXml fails because of bug
Thanks,
Paul Isaychuk
Re: Review Request 35061: [FALCON-1254] ClusterSetup UI: edit xml
test cases, fix testLocationsBadPermissions, testDefaultScenario
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35061/#review87164
-----------------------------------------------------------
Ship it!
Ship It!
- Ruslan Ostafiychuk
On June 8, 2015, 1:58 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35061/
> -----------------------------------------------------------
>
> (Updated June 8, 2015, 1:58 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1254
> https://issues.apache.org/jira/browse/FALCON-1254
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Adding testEditXml, testEditXmlInvalidValues. Fix testLocationsBadPermissions (alert message), testDefaultScenario (extra step while parsing properties).
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 92b1ee5
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java d616b84
>
> Diff: https://reviews.apache.org/r/35061/diff/
>
>
> Testing
> -------
>
> checkstyle passed
> testEditXml fails because of bug
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 35061: [FALCON-1254] ClusterSetup UI: edit xml
test cases, fix testLocationsBadPermissions, testDefaultScenario
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35061/
-----------------------------------------------------------
(Updated June 8, 2015, 1:58 p.m.)
Review request for Falcon.
Changes
-------
comments addressed
Bugs: FALCON-1254
https://issues.apache.org/jira/browse/FALCON-1254
Repository: falcon-git
Description
-------
Adding testEditXml, testEditXmlInvalidValues. Fix testLocationsBadPermissions (alert message), testDefaultScenario (extra step while parsing properties).
Diffs (updated)
-----
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 92b1ee5
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java d616b84
Diff: https://reviews.apache.org/r/35061/diff/
Testing
-------
checkstyle passed
testEditXml fails because of bug
Thanks,
Paul Isaychuk
Re: Review Request 35061: [FALCON-1254] ClusterSetup UI: edit xml
test cases, fix testLocationsBadPermissions, testDefaultScenario
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35061/#review86593
-----------------------------------------------------------
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java
<https://reviews.apache.org/r/35061/#comment138649>
would be better to extract webElement to some private method
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java
<https://reviews.apache.org/r/35061/#comment138652>
clicks can be included into setClusterXml method
- Ruslan Ostafiychuk
On June 4, 2015, 12:07 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35061/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 12:07 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1254
> https://issues.apache.org/jira/browse/FALCON-1254
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Adding testEditXml, testEditXmlInvalidValues. Fix testLocationsBadPermissions (alert message), testDefaultScenario (extra step while parsing properties).
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 92b1ee5
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java d616b84
>
> Diff: https://reviews.apache.org/r/35061/diff/
>
>
> Testing
> -------
>
> checkstyle passed
> testEditXml fails because of bug
>
>
> Thanks,
>
> Paul Isaychuk
>
>