You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Narayan Periwal <na...@inmobi.com> on 2015/08/25 08:39:57 UTC
Review Request 37749: FALCON-1414: Add all fields in filterBy to the
entity list output.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37749/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
falcon entity -list -type process -filterBy STATUS:RUNNING,CLUSTER:lhr1-emerald
(PROCESS) FETL-Enhancer-Deferred
(PROCESS) FETL-Enhancer
(PROCESS) FETL-ConversionRC-conversion
Currently, entity list outputs only the name. Adding the filters that are specified in the filterBy, to the list output, will be useful to the user.
Diffs
-----
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java f2f9826
Diff: https://reviews.apache.org/r/37749/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 37749: FALCON-1414: Add all fields in filterBy to
the entity list output.
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37749/#review96510
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Aug. 26, 2015, 7:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37749/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 7:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> falcon entity -list -type process -filterBy STATUS:RUNNING,CLUSTER:lhr1-emerald
> (PROCESS) FETL-Enhancer-Deferred
> (PROCESS) FETL-Enhancer
> (PROCESS) FETL-ConversionRC-conversion
>
> Currently, entity list outputs only the name. Adding the filters that are specified in the filterBy, to the list output, will be useful to the user.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
> prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java cce8737
>
> Diff: https://reviews.apache.org/r/37749/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 37749: FALCON-1414: Add all fields in filterBy to
the entity list output.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37749/#review98007
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Aug. 26, 2015, 7:10 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37749/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 7:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> falcon entity -list -type process -filterBy STATUS:RUNNING,CLUSTER:lhr1-emerald
> (PROCESS) FETL-Enhancer-Deferred
> (PROCESS) FETL-Enhancer
> (PROCESS) FETL-ConversionRC-conversion
>
> Currently, entity list outputs only the name. Adding the filters that are specified in the filterBy, to the list output, will be useful to the user.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
> prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java cce8737
>
> Diff: https://reviews.apache.org/r/37749/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 37749: FALCON-1414: Add all fields in filterBy to
the entity list output.
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37749/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 7:10 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
falcon entity -list -type process -filterBy STATUS:RUNNING,CLUSTER:lhr1-emerald
(PROCESS) FETL-Enhancer-Deferred
(PROCESS) FETL-Enhancer
(PROCESS) FETL-ConversionRC-conversion
Currently, entity list outputs only the name. Adding the filters that are specified in the filterBy, to the list output, will be useful to the user.
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java cce8737
Diff: https://reviews.apache.org/r/37749/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 37749: FALCON-1414: Add all fields in filterBy to
the entity list output.
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37749/#review96311
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 584)
<https://reviews.apache.org/r/37749/#comment151631>
If you are using only the keys.. you might as well just use filterByFieldsValues.keySet()
- Pallavi Rao
On Aug. 25, 2015, 6:39 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37749/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 6:39 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> falcon entity -list -type process -filterBy STATUS:RUNNING,CLUSTER:lhr1-emerald
> (PROCESS) FETL-Enhancer-Deferred
> (PROCESS) FETL-Enhancer
> (PROCESS) FETL-ConversionRC-conversion
>
> Currently, entity list outputs only the name. Adding the filters that are specified in the filterBy, to the list output, will be useful to the user.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java f2f9826
>
> Diff: https://reviews.apache.org/r/37749/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 37749: FALCON-1414: Add all fields in filterBy to
the entity list output.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37749/#review96320
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 585)
<https://reviews.apache.org/r/37749/#comment151637>
Can you please add a unit test also for it? See EntityManagerTest class.
- Ajay Yadava
On Aug. 25, 2015, 6:39 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37749/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 6:39 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> falcon entity -list -type process -filterBy STATUS:RUNNING,CLUSTER:lhr1-emerald
> (PROCESS) FETL-Enhancer-Deferred
> (PROCESS) FETL-Enhancer
> (PROCESS) FETL-ConversionRC-conversion
>
> Currently, entity list outputs only the name. Adding the filters that are specified in the filterBy, to the list output, will be useful to the user.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java f2f9826
>
> Diff: https://reviews.apache.org/r/37749/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>