You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/05/07 00:36:55 UTC
Review Request 47083: transfer the system property for log4j from
gradle to unit test framework
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47083/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: geode-1360
https://issues.apache.org/jira/browse/geode-1360
Repository: geode
Description
-------
The gradle need to accept the system property and send to test framework.
The test framework should accept the system property log4j.configurationFile
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java be459b9
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java dd532c4
gradle/test.gradle 2dd7521
Diff: https://reviews.apache.org/r/47083/diff/
Testing
-------
Thanks,
xiaojian zhou
Re: Review Request 47083: transfer the system property for log4j from
gradle to unit test framework
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47083/#review132361
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On May 10, 2016, 12:37 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47083/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 12:37 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: geode-1360
> https://issues.apache.org/jira/browse/geode-1360
>
>
> Repository: geode
>
>
> Description
> -------
>
> The gradle need to accept the system property and send to test framework.
>
> The test framework should accept the system property log4j.configurationFile
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 0c294ec
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java dd532c4
> gradle/test.gradle 2dd7521
>
> Diff: https://reviews.apache.org/r/47083/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 47083: transfer the system property for log4j from
gradle to unit test framework
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47083/
-----------------------------------------------------------
(Updated May 10, 2016, 12:37 a.m.)
Review request for geode and Dan Smith.
Changes
-------
fixed the bug in ProcessManager
Bugs: geode-1360
https://issues.apache.org/jira/browse/geode-1360
Repository: geode
Description
-------
The gradle need to accept the system property and send to test framework.
The test framework should accept the system property log4j.configurationFile
Diffs (updated)
-----
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java 0c294ec
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java dd532c4
gradle/test.gradle 2dd7521
Diff: https://reviews.apache.org/r/47083/diff/
Testing
-------
Thanks,
xiaojian zhou
Re: Review Request 47083: transfer the system property for log4j from
gradle to unit test framework
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47083/#review132321
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On May 7, 2016, 12:36 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47083/
> -----------------------------------------------------------
>
> (Updated May 7, 2016, 12:36 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: geode-1360
> https://issues.apache.org/jira/browse/geode-1360
>
>
> Repository: geode
>
>
> Description
> -------
>
> The gradle need to accept the system property and send to test framework.
>
> The test framework should accept the system property log4j.configurationFile
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/DUnitLauncher.java be459b9
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java dd532c4
> gradle/test.gradle 2dd7521
>
> Diff: https://reviews.apache.org/r/47083/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>