[GitHub] [incubator-doris] stdpain commented on a change in pull request #5514: [BUG] fix memory limit failure and optimize memory usage in join stage

[GitBox <gi...@apache.org>]

stdpain commented on a change in pull request #5514:
URL: https://github.com/apache/incubator-doris/pull/5514#discussion_r595019164



##########
File path: be/src/exec/hash_join_node_ir.cpp
##########
@@ -118,7 +119,10 @@ int HashJoinNode::process_probe_batch(RowBatch* out_batch, RowBatch* probe_batch
             if (UNLIKELY(_probe_batch_pos == probe_rows)) {
                 goto end;
             }
-
+            if (++_probe_counter % _release_context_counter == 0) {
+                ExprContext::free_local_allocations(_probe_expr_ctxs);
+                ExprContext::free_local_allocations(_build_expr_ctxs);

Review comment:
       build_expr_context also will be called in join stage




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org