[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #441: autogenview: fix fill edit/update forms

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #441:
URL: https://github.com/apache/cloudstack-primate/pull/441#discussion_r444621521



##########
File path: src/views/AutogenView.vue
##########
@@ -740,7 +740,8 @@ export default {
       this.currentAction.paramFields.map(field => {
         let fieldValue = null
         let fieldName = null
-        if (field.type === 'list' || field.name === 'account' || (this.currentAction.mapping && field.name in this.currentAction.mapping)) {
+        if (field.type === 'list' || field.name === 'account' ||
+          (this.currentAction.mapping && field.name in this.currentAction.mapping && !(field.name in this.resource))) {

Review comment:
       actually a field name could have a custom mapping and be in a resource (there are a few example), so this may break such cases; can you fix it by rather adding a mapping to the edit host action @shwstppr but retain the `this.currentAction.mapping && field.name in this.currentAction.mapping` check




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org