[GitHub] [drill] vvysotskyi commented on a change in pull request #2388: DRILL-8057: INFORMATION_SCHEMA filter push down is inefficient

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #2388:
URL: https://github.com/apache/drill/pull/2388#discussion_r758726205



##########
File path: exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java
##########
@@ -64,13 +64,13 @@ public static void setupFiles() {
 
   @Test
   public void selectFromAllTables() throws Exception{
-    test("select * from INFORMATION_SCHEMA.SCHEMATA");
-    test("select * from INFORMATION_SCHEMA.CATALOGS");
-    test("select * from INFORMATION_SCHEMA.VIEWS");
-    test("select * from INFORMATION_SCHEMA.`TABLES`");
-    test("select * from INFORMATION_SCHEMA.COLUMNS");
-    test("select * from INFORMATION_SCHEMA.`FILES`");
-    test("select * from INFORMATION_SCHEMA.`PARTITIONS`");
+//    test("select * from INFORMATION_SCHEMA.SCHEMATA");
+//    test("select * from INFORMATION_SCHEMA.CATALOGS");
+//    test("select * from INFORMATION_SCHEMA.VIEWS");
+    test("select * from INFORMATION_SCHEMA.`TABLES` where table_schema = 'cp.default'");
+//    test("select * from INFORMATION_SCHEMA.COLUMNS");
+//    test("select * from INFORMATION_SCHEMA.`FILES`");
+//    test("select * from INFORMATION_SCHEMA.`PARTITIONS`");

Review comment:
       Please add a new test instead of changing the existing one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org