You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/09/23 06:39:38 UTC
[GitHub] [calcite] hsyuan commented on a change in pull request #1451:
[CALCITE-3334] Refinement for Substitution-Based MV Matching
hsyuan commented on a change in pull request #1451: [CALCITE-3334] Refinement for Substitution-Based MV Matching
URL: https://github.com/apache/calcite/pull/1451#discussion_r326963172
##########
File path: core/src/main/java/org/apache/calcite/plan/MaterializedViewSubstitutionVisitor.java
##########
@@ -39,9 +39,9 @@
private static final ImmutableList<UnifyRule> EXTENDED_RULES =
ImmutableList.<UnifyRule>builder()
.addAll(DEFAULT_RULES)
- .add(ProjectToProjectUnifyRule1.INSTANCE)
- .add(FilterToFilterUnifyRule1.INSTANCE)
- .add(FilterToProjectUnifyRule1.INSTANCE)
+// .add(ProjectToProjectUnifyRule1.INSTANCE)
+// .add(FilterToFilterUnifyRule1.INSTANCE)
+// .add(FilterToProjectUnifyRule1.INSTANCE)
Review comment:
It works, so now you can remove them instead of commenting out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services