You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/22 00:09:21 UTC
[GitHub] [phoenix] joshelser commented on a change in pull request #837: PHOENIX-6016 Support HBase 2.3.0
joshelser commented on a change in pull request #837:
URL: https://github.com/apache/phoenix/pull/837#discussion_r458458131
##########
File path: phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALReplayWithIndexWritesAndCompressedWALIT.java
##########
@@ -176,11 +177,15 @@ private void deleteDir(final Path p) throws IOException {
*/
@Test
public void testReplayEditsWrittenViaHRegion() throws Exception {
- final String tableNameStr = "testReplayEditsWrittenViaHRegion";
- final RegionInfo hri = RegionInfoBuilder.newBuilder(org.apache.hadoop.hbase.TableName.valueOf(tableNameStr)).setSplit(false).build();
- final Path basedir = FSUtils.getTableDir(hbaseRootDir, org.apache.hadoop.hbase.TableName.valueOf(tableNameStr));
- deleteDir(basedir);
- final TableDescriptor htd = createBasic3FamilyHTD(tableNameStr);
+ final String tableNameStr = "testReplayEditsWrittenViaHRegion";
+ final RegionInfo hri =
+ RegionInfoBuilder.newBuilder(org.apache.hadoop.hbase.TableName.valueOf(tableNameStr))
Review comment:
Why the fully-qualified TableName?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org