You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/12/15 21:25:54 UTC
Re: Review Request 64522: Made OfferOperationStatusUpdateManager
tests pass on Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64522/
-----------------------------------------------------------
(Updated Dec. 15, 2017, 1:25 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Greg Mann, and Jie Yu.
Summary (updated)
-----------------
Made OfferOperationStatusUpdateManager tests pass on Windows.
Repository: mesos
Description (updated)
-------
See the summary.
Diffs
-----
src/status_update_manager/status_update_manager_process.hpp e575d8c31bb6bd63fc26f01e2deec5f44821e01c
src/tests/offer_operation_status_update_manager_tests.cpp cb71bc10f9a687f12ee4cca4f8fa8614f5ea2d58
Diff: https://reviews.apache.org/r/64522/diff/10/
Testing (updated)
-------
It took a while, but the Windows reviewbot is now happy =).
Thanks,
Gaston Kleiman
Re: Review Request 64522: Made OfferOperationStatusUpdateManager
tests pass on Windows.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64522/#review193999
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On Dec. 15, 2017, 1:25 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64522/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 1:25 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See the summary.
>
>
> Diffs
> -----
>
> src/status_update_manager/status_update_manager_process.hpp e575d8c31bb6bd63fc26f01e2deec5f44821e01c
> src/tests/offer_operation_status_update_manager_tests.cpp cb71bc10f9a687f12ee4cca4f8fa8614f5ea2d58
>
>
> Diff: https://reviews.apache.org/r/64522/diff/10/
>
>
> Testing
> -------
>
> It took a while, but the Windows reviewbot is now happy =).
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64522: Made OfferOperationStatusUpdateManager
tests pass on Windows.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64522/#review194000
-----------------------------------------------------------
src/status_update_manager/status_update_manager_process.hpp
Lines 635-637 (patched)
<https://reviews.apache.org/r/64522/#comment272693>
This weird Windows-ism is biting us in a lot of places. We've had to fix it elsewhere previously, and I have a dirty tree with the same fix applied to `net::download`.
We should commit this as-is for now. I will follow up with a patch to `os::open` itself to default to this behavior on Windows, possibly with an optional argument to turn it off if needed. I have a hunch, however, that nothing in Mesos expects or wants the "text mode" of Windows where it translates all your newlines to CRLFs.
- Andrew Schwartzmeyer
On Dec. 15, 2017, 1:25 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64522/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 1:25 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Greg Mann, and Jie Yu.
>
>
> Bugs: MESOS-8318
> https://issues.apache.org/jira/browse/MESOS-8318
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See the summary.
>
>
> Diffs
> -----
>
> src/status_update_manager/status_update_manager_process.hpp e575d8c31bb6bd63fc26f01e2deec5f44821e01c
> src/tests/offer_operation_status_update_manager_tests.cpp cb71bc10f9a687f12ee4cca4f8fa8614f5ea2d58
>
>
> Diff: https://reviews.apache.org/r/64522/diff/10/
>
>
> Testing
> -------
>
> It took a while, but the Windows reviewbot is now happy =).
>
>
> Thanks,
>
> Gaston Kleiman
>
>