You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/23 17:59:26 UTC
[GitHub] [airflow] aspain opened a new pull request, #24622: adding option to use non-default gcp_conn_id
aspain opened a new pull request, #24622:
URL: https://github.com/apache/airflow/pull/24622
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #24494
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24622: adding option to use non-default gcp_conn_id in GoogleDriveToLocalOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24622:
URL: https://github.com/apache/airflow/pull/24622#issuecomment-1164788679
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aspain commented on pull request #24622: adding option to use non-default gcp_conn_id
Posted by GitBox <gi...@apache.org>.
aspain commented on PR #24622:
URL: https://github.com/apache/airflow/pull/24622#issuecomment-1164710435
For https://github.com/apache/airflow/issues/24494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #24622: Add gcp_conn_id argument to GoogleDriveToLocalOperator
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #24622:
URL: https://github.com/apache/airflow/pull/24622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #24622: adding option to use non-default gcp_conn_id in GoogleDriveToLocalOperator
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #24622:
URL: https://github.com/apache/airflow/pull/24622#discussion_r905764022
##########
tests/providers/google/cloud/transfers/test_gdrive_to_local.py:
##########
@@ -18,28 +18,36 @@
from tempfile import NamedTemporaryFile
from unittest import TestCase, mock
-from airflow.providers.google.cloud.transfers.gdrive_to_local import GoogleDriveToLocalOperator
+from airflow.providers.google.cloud.transfers.gdrive_to_local import (
+ GoogleDriveToLocalOperator,
+)
TASK_ID = "test-drive-to-local-operator"
FOLDER_ID = "1234567890qwerty"
FILE_NAME = "file.pdf"
+GCP_CONN_ID = "google_cloud_default"
class TestGoogleDriveToLocalOperator(TestCase):
- @mock.patch("airflow.providers.google.cloud.transfers.gdrive_to_local.GoogleDriveHook")
+ @mock.patch(
+ "airflow.providers.google.cloud.transfers.gdrive_to_local.GoogleDriveHook"
+ )
Review Comment:
```suggestion
@mock.patch("airflow.providers.google.cloud.transfers.gdrive_to_local.GoogleDriveHook")
```
##########
tests/providers/google/cloud/transfers/test_gdrive_to_local.py:
##########
@@ -18,28 +18,36 @@
from tempfile import NamedTemporaryFile
from unittest import TestCase, mock
-from airflow.providers.google.cloud.transfers.gdrive_to_local import GoogleDriveToLocalOperator
+from airflow.providers.google.cloud.transfers.gdrive_to_local import (
+ GoogleDriveToLocalOperator,
+)
Review Comment:
```suggestion
from airflow.providers.google.cloud.transfers.gdrive_to_local import GoogleDriveToLocalOperator
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #24622: adding option to use non-default gcp_conn_id in GoogleDriveToLocalOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on PR #24622:
URL: https://github.com/apache/airflow/pull/24622#issuecomment-1164992124
Black is still sad 😿
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org