You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/05/30 02:16:56 UTC
Review Request: Updated a fault-tolerant test to deal with updates in
libprocess. This included changing some constant names to be more
descriptive and updating the WAIT_UNTIL abstraction to be more general and
work with arbitrary expressions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5264/
-----------------------------------------------------------
Review request for mesos, John Sirois and Vinod Kone.
Summary
-------
See summary.
Diffs
-----
src/master/constants.hpp c3b0b25
src/master/master.cpp 89cdaf6
src/tests/fault_tolerance_tests.cpp b2529ca
src/tests/utils.hpp e81ec82
Diff: https://reviews.apache.org/r/5264/diff
Testing
-------
make check
Thanks,
Benjamin
Re: Review Request: Updated a fault-tolerant test to deal with updates in
libprocess. This included changing some constant names to be more
descriptive and updating the WAIT_UNTIL abstraction to be more general and
work with arbitrary expressions.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On May 30, 2012, 6:20 a.m., John Sirois wrote:
> > src/tests/utils.hpp, line 264
> > <https://reviews.apache.org/r/5264/diff/1/?file=110547#file110547line264>
> >
> > s/'increment'/'decrement'/
Thanks, done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5264/#review8188
-----------------------------------------------------------
On May 30, 2012, 12:16 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5264/
> -----------------------------------------------------------
>
> (Updated May 30, 2012, 12:16 a.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/constants.hpp c3b0b25
> src/master/master.cpp 89cdaf6
> src/tests/fault_tolerance_tests.cpp b2529ca
> src/tests/utils.hpp e81ec82
>
> Diff: https://reviews.apache.org/r/5264/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Updated a fault-tolerant test to deal with updates in
libprocess. This included changing some constant names to be more
descriptive and updating the WAIT_UNTIL abstraction to be more general and
work with arbitrary expressions.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5264/#review8188
-----------------------------------------------------------
Ship it!
src/tests/utils.hpp
<https://reviews.apache.org/r/5264/#comment17737>
s/'increment'/'decrement'/
- John
On 2012-05-30 00:16:56, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5264/
> -----------------------------------------------------------
>
> (Updated 2012-05-30 00:16:56)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/constants.hpp c3b0b25
> src/master/master.cpp 89cdaf6
> src/tests/fault_tolerance_tests.cpp b2529ca
> src/tests/utils.hpp e81ec82
>
> Diff: https://reviews.apache.org/r/5264/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Updated a fault-tolerant test to deal with updates in
libprocess. This included changing some constant names to be more
descriptive and updating the WAIT_UNTIL abstraction to be more general and
work with arbitrary expressions.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On May 30, 2012, 4:42 p.m., Vinod Kone wrote:
> > src/tests/utils.hpp, line 299
> > <https://reviews.apache.org/r/5264/diff/1/?file=110547#file110547line299>
> >
> > can be 'e' be coerced into output here?
Totally awesome idea, done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5264/#review8215
-----------------------------------------------------------
On May 30, 2012, 12:16 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5264/
> -----------------------------------------------------------
>
> (Updated May 30, 2012, 12:16 a.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/constants.hpp c3b0b25
> src/master/master.cpp 89cdaf6
> src/tests/fault_tolerance_tests.cpp b2529ca
> src/tests/utils.hpp e81ec82
>
> Diff: https://reviews.apache.org/r/5264/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Updated a fault-tolerant test to deal with updates in
libprocess. This included changing some constant names to be more
descriptive and updating the WAIT_UNTIL abstraction to be more general and
work with arbitrary expressions.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5264/#review8215
-----------------------------------------------------------
Ship it!
src/tests/fault_tolerance_tests.cpp
<https://reviews.apache.org/r/5264/#comment17763>
cool!
src/tests/utils.hpp
<https://reviews.apache.org/r/5264/#comment17764>
can be 'e' be coerced into output here?
- Vinod
On 2012-05-30 00:16:56, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5264/
> -----------------------------------------------------------
>
> (Updated 2012-05-30 00:16:56)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/constants.hpp c3b0b25
> src/master/master.cpp 89cdaf6
> src/tests/fault_tolerance_tests.cpp b2529ca
> src/tests/utils.hpp e81ec82
>
> Diff: https://reviews.apache.org/r/5264/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>