You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2019/06/04 07:31:22 UTC
[kudu-CR] [rebalance] remove unused function declaration and fix typo error in comment.
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13505
Change subject: [rebalance] remove unused function declaration and fix typo error in comment.
......................................................................
[rebalance] remove unused function declaration and fix typo error in comment.
GetNextMoves(Runner* runner,std::vector<ReplicaMove>* replica_moves) was
a function used in previous versions, it seems useless now.
Change-Id: Id3eac211f80d7ec36897488b4f56fe9ed92072ff
---
M src/kudu/tools/rebalance_algo.h
M src/kudu/tools/rebalancer.h
2 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/13505/1
--
To view, visit http://gerrit.cloudera.org:8080/13505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3eac211f80d7ec36897488b4f56fe9ed92072ff
Gerrit-Change-Number: 13505
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] [rebalance] remove unused function declaration and fix typo error in comment.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13505 )
Change subject: [rebalance] remove unused function declaration and fix typo error in comment.
......................................................................
[rebalance] remove unused function declaration and fix typo error in comment.
GetNextMoves(Runner* runner,std::vector<ReplicaMove>* replica_moves) was
a function used in previous versions, it seems useless now.
Change-Id: Id3eac211f80d7ec36897488b4f56fe9ed92072ff
Reviewed-on: http://gerrit.cloudera.org:8080/13505
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/rebalance_algo.h
M src/kudu/tools/rebalancer.h
2 files changed, 1 insertion(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3eac211f80d7ec36897488b4f56fe9ed92072ff
Gerrit-Change-Number: 13505
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [rebalance] remove unused function declaration and fix typo error in comment.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13505 )
Change subject: [rebalance] remove unused function declaration and fix typo error in comment.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3eac211f80d7ec36897488b4f56fe9ed92072ff
Gerrit-Change-Number: 13505
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 04 Jun 2019 07:37:14 +0000
Gerrit-HasComments: No