You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/02 13:45:27 UTC

[GitHub] [flink] StephanEwen opened a new pull request #13533: [FLINK-19492][core] Consolidate Source Events between Source API and Split Reader API

StephanEwen opened a new pull request #13533:
URL: https://github.com/apache/flink/pull/13533


   ## What is the purpose of the change
   
   Consolidation between the Source API event classes in `flink-core` and `flink-connector-base`.
   
   There is no only one implementation of each event, in `flink-core` that is shared by implementations of the Source API and the SplitReader API.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13533: [FLINK-19492][core] Consolidate Source Events between Source API and Split Reader API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13533:
URL: https://github.com/apache/flink/pull/13533#issuecomment-702751205


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f51dc9f4ac715b154f9e2e9158af448cecd54ea1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7166",
       "triggerID" : "f51dc9f4ac715b154f9e2e9158af448cecd54ea1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f51dc9f4ac715b154f9e2e9158af448cecd54ea1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7166) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13533: [FLINK-19492][core] Consolidate Source Events between Source API and Split Reader API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13533:
URL: https://github.com/apache/flink/pull/13533#issuecomment-702751205


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f51dc9f4ac715b154f9e2e9158af448cecd54ea1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7166",
       "triggerID" : "f51dc9f4ac715b154f9e2e9158af448cecd54ea1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f51dc9f4ac715b154f9e2e9158af448cecd54ea1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7166) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13533: [FLINK-19492][core] Consolidate Source Events between Source API and Split Reader API

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13533:
URL: https://github.com/apache/flink/pull/13533#issuecomment-702751205


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f51dc9f4ac715b154f9e2e9158af448cecd54ea1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f51dc9f4ac715b154f9e2e9158af448cecd54ea1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f51dc9f4ac715b154f9e2e9158af448cecd54ea1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #13533: [FLINK-19492][core] Consolidate Source Events between Source API and Split Reader API

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #13533:
URL: https://github.com/apache/flink/pull/13533#issuecomment-706997633


   Thanks, merging this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] asfgit closed pull request #13533: [FLINK-19492][core] Consolidate Source Events between Source API and Split Reader API

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #13533:
URL: https://github.com/apache/flink/pull/13533


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13533: [FLINK-19492][core] Consolidate Source Events between Source API and Split Reader API

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13533:
URL: https://github.com/apache/flink/pull/13533#issuecomment-702744410


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit f51dc9f4ac715b154f9e2e9158af448cecd54ea1 (Fri Oct 02 13:48:24 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org