You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/10/23 19:50:34 UTC
Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see JIRA
https://issues.apache.org/jira/browse/SQOOP-1514
https://issues.apache.org/jira/browse/SQOOP-1512
and the parent ticket:
https://issues.apache.org/jira/browse/SQOOP-1509
It modifies the driver api and connector api.
It adds a configurable api with java docs on how to use it.
The relevant constants have been moved to their respective classes
There are WS, that will be cleaned up soon
Diffs
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml d31120a
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
Diff: https://reviews.apache.org/r/27095/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 23, 2014, 2:52 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, line 111
> > <https://reviews.apache.org/r/27095/diff/3/?file=731022#file731022line111>
> >
> > Is there going to be documentation for all of the changes to the JSON structure?
>
> Veena Basavaraj wrote:
> Yes, there is a ticket for it.
https://issues.apache.org/jira/browse/SQOOP-1518
> On Oct. 23, 2014, 2:52 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, lines 20-21
> > <https://reviews.apache.org/r/27095/diff/3/?file=731022#file731022line20>
> >
> > NIT: Use full names instead of .*?
>
> Veena Basavaraj wrote:
> I spoke to Jarcec on the derby schema stuff, it is a pain with the merge always. Is there a performance implication doing *?
>
> Abraham Elmahrek wrote:
> It's more of a clutter thing I guess. Traditionally we've avoided using wildcard imports. Unless every thing from the global space of each of those packages is being imported, it's probably less cluttered to do use non-wildcard imports. Even if the entirety of the package is being used, there's always a chance that new items will be added that won't be used in the future as well.
hmm... not sure if it matters, I can change it back
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58112
-----------------------------------------------------------
On Oct. 23, 2014, 1:10 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 1:10 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Oct. 23, 2014, 9:52 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, lines 20-21
> > <https://reviews.apache.org/r/27095/diff/3/?file=731022#file731022line20>
> >
> > NIT: Use full names instead of .*?
>
> Veena Basavaraj wrote:
> I spoke to Jarcec on the derby schema stuff, it is a pain with the merge always. Is there a performance implication doing *?
It's more of a clutter thing I guess. Traditionally we've avoided using wildcard imports. Unless every thing from the global space of each of those packages is being imported, it's probably less cluttered to do use non-wildcard imports. Even if the entirety of the package is being used, there's always a chance that new items will be added that won't be used in the future as well.
> On Oct. 23, 2014, 9:52 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/LinkBean.java, lines 115-122
> > <https://reviews.apache.org/r/27095/diff/3/?file=731026#file731026line115>
> >
> > If we've split up the APIs for fetch bundles and resources, then this line of code is unnecessary. Otherwise, the bundles should probably be shipped with responses to resource requests.
>
> Veena Basavaraj wrote:
> yes the link config GET resource will add this( it is nother ticket)
>
> it is in the design pdf attached
> v1/connector/{cname}/link GET A connector has zero or more links.Hence
> the api list the parent/child relationship in
> the REST api
> Gets the config params associated to create
> a link object for this connector ( used in the
> context of UI in Hue to show the list of
> params to fill out). It could also be an api on
> the config resource ( still up for discussion )
>
> the bundles are shipped with connectors/ drivers that are configurables as well.
>
> Veena Basavaraj wrote:
> I will remvoe this comment and fix it in the next RB that has LINK and JOB related changes
That works.
> On Oct. 23, 2014, 9:52 p.m., Abraham Elmahrek wrote:
> > server/src/main/webapp/WEB-INF/web.xml, lines 67-71
> > <https://reviews.apache.org/r/27095/diff/3/?file=731056#file731056line67>
> >
> > Does this need to be redefined?
>
> Veena Basavaraj wrote:
> it connector and connectors yes 2 separate ones.
Ah yes, one is plural. See it now.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58112
-----------------------------------------------------------
On Oct. 23, 2014, 8:10 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 8:10 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 23, 2014, 2:52 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, lines 20-21
> > <https://reviews.apache.org/r/27095/diff/3/?file=731022#file731022line20>
> >
> > NIT: Use full names instead of .*?
I spoke to Jarcec on the derby schema stuff, it is a pain with the merge always. Is there a performance implication doing *?
> On Oct. 23, 2014, 2:52 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, line 111
> > <https://reviews.apache.org/r/27095/diff/3/?file=731022#file731022line111>
> >
> > Is there going to be documentation for all of the changes to the JSON structure?
Yes, there is a ticket for it.
> On Oct. 23, 2014, 2:52 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/LinkBean.java, lines 115-122
> > <https://reviews.apache.org/r/27095/diff/3/?file=731026#file731026line115>
> >
> > If we've split up the APIs for fetch bundles and resources, then this line of code is unnecessary. Otherwise, the bundles should probably be shipped with responses to resource requests.
yes the link config GET resource will add this( it is nother ticket)
it is in the design pdf attached
v1/connector/{cname}/link GET A connector has zero or more links.Hence
the api list the parent/child relationship in
the REST api
Gets the config params associated to create
a link object for this connector ( used in the
context of UI in Hue to show the list of
params to fill out). It could also be an api on
the config resource ( still up for discussion )
the bundles are shipped with connectors/ drivers that are configurables as well.
> On Oct. 23, 2014, 2:52 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/model/MConfigList.java, lines 87-88
> > <https://reviews.apache.org/r/27095/diff/3/?file=731033#file731033line87>
> >
> > NIT: Braces?
fixed
> On Oct. 23, 2014, 2:52 p.m., Abraham Elmahrek wrote:
> > server/src/main/webapp/WEB-INF/web.xml, lines 67-71
> > <https://reviews.apache.org/r/27095/diff/3/?file=731056#file731056line67>
> >
> > Does this need to be redefined?
it connector and connectors yes 2 separate ones.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58112
-----------------------------------------------------------
On Oct. 23, 2014, 1:10 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 1:10 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 23, 2014, 2:52 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/LinkBean.java, lines 115-122
> > <https://reviews.apache.org/r/27095/diff/3/?file=731026#file731026line115>
> >
> > If we've split up the APIs for fetch bundles and resources, then this line of code is unnecessary. Otherwise, the bundles should probably be shipped with responses to resource requests.
>
> Veena Basavaraj wrote:
> yes the link config GET resource will add this( it is nother ticket)
>
> it is in the design pdf attached
> v1/connector/{cname}/link GET A connector has zero or more links.Hence
> the api list the parent/child relationship in
> the REST api
> Gets the config params associated to create
> a link object for this connector ( used in the
> context of UI in Hue to show the list of
> params to fill out). It could also be an api on
> the config resource ( still up for discussion )
>
> the bundles are shipped with connectors/ drivers that are configurables as well.
I will remvoe this comment and fix it in the next RB that has LINK and JOB related changes
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58112
-----------------------------------------------------------
On Oct. 23, 2014, 1:10 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 1:10 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58112
-----------------------------------------------------------
A few nits and thoughts. Also, remember to kill off all extra whitespaces.
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
<https://reviews.apache.org/r/27095/#comment99010>
NIT: Use full names instead of .*?
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
<https://reviews.apache.org/r/27095/#comment99014>
Is there going to be documentation for all of the changes to the JSON structure?
common/src/main/java/org/apache/sqoop/json/LinkBean.java
<https://reviews.apache.org/r/27095/#comment99017>
If we've split up the APIs for fetch bundles and resources, then this line of code is unnecessary. Otherwise, the bundles should probably be shipped with responses to resource requests.
common/src/main/java/org/apache/sqoop/json/LinkBean.java
<https://reviews.apache.org/r/27095/#comment99018>
See above comment
common/src/main/java/org/apache/sqoop/model/MConfigList.java
<https://reviews.apache.org/r/27095/#comment99020>
NIT: Braces?
server/src/main/webapp/WEB-INF/web.xml
<https://reviews.apache.org/r/27095/#comment99024>
Does this need to be redefined?
- Abraham Elmahrek
On Oct. 23, 2014, 8:10 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 8:10 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 23, 2014, 5:50 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, line 88
> > <https://reviews.apache.org/r/27095/diff/5/?file=731689#file731689line88>
> >
> > Shouldn't this vary by API?
> >
> > For example, /connectors/ => CONNECTORS and /connectors/1/ => CONNECTOR.
>
> Veena Basavaraj wrote:
> yes it does, hence so
fixed
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58172
-----------------------------------------------------------
On Oct. 23, 2014, 4:35 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 4:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 23, 2014, 5:50 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, lines 57-58
> > <https://reviews.apache.org/r/27095/diff/5/?file=731689#file731689line57>
> >
> > Hyphenated case (if there is such a thing)?
sorry I did not get it. It is pretty much a practice not to use hyphens in JSON values, I have seen here the first.
> On Oct. 23, 2014, 5:50 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, line 88
> > <https://reviews.apache.org/r/27095/diff/5/?file=731689#file731689line88>
> >
> > Shouldn't this vary by API?
> >
> > For example, /connectors/ => CONNECTORS and /connectors/1/ => CONNECTOR.
yes it does, hence so
> On Oct. 23, 2014, 5:50 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/JsonBean.java, line 26
> > <https://reviews.apache.org/r/27095/diff/5/?file=731692#file731692line26>
> >
> > I can see how "configs" didn't really fit for what these provide. The value associated with this key should be the resource bundles. Would "properties" or "resources" work?
> >
> > `allConfigParams` is in camel case. How about using hyphens to separate words for serialization?
same as above, I never seen this as a convention to use hyphens in JSON.
If we seen the connector api, we have consistently used configs there, might be ok to call them just configs. But I wanted ot have all since we dont slit them by type here.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58172
-----------------------------------------------------------
On Oct. 23, 2014, 4:35 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 4:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 23, 2014, 5:50 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/JsonBean.java, line 26
> > <https://reviews.apache.org/r/27095/diff/5/?file=731692#file731692line26>
> >
> > I can see how "configs" didn't really fit for what these provide. The value associated with this key should be the resource bundles. Would "properties" or "resources" work?
> >
> > `allConfigParams` is in camel case. How about using hyphens to separate words for serialization?
>
> Veena Basavaraj wrote:
> same as above, I never seen this as a convention to use hyphens in JSON.
>
> If we seen the connector api, we have consistently used configs there, might be ok to call them just configs. But I wanted ot have all since we dont slit them by type here.
lots of JS libraries..have issues with hyphens in the JSON keys
http://stackoverflow.com/questions/17582367/angularjs-templates-cant-use-json-that-contains-hyphen
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58172
-----------------------------------------------------------
On Oct. 23, 2014, 4:35 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 4:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 23, 2014, 5:50 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/JsonBean.java, line 26
> > <https://reviews.apache.org/r/27095/diff/5/?file=731692#file731692line26>
> >
> > I can see how "configs" didn't really fit for what these provide. The value associated with this key should be the resource bundles. Would "properties" or "resources" work?
> >
> > `allConfigParams` is in camel case. How about using hyphens to separate words for serialization?
>
> Veena Basavaraj wrote:
> same as above, I never seen this as a convention to use hyphens in JSON.
>
> If we seen the connector api, we have consistently used configs there, might be ok to call them just configs. But I wanted ot have all since we dont slit them by type here.
>
> Veena Basavaraj wrote:
> lots of JS libraries..have issues with hyphens in the JSON keys
>
> http://stackoverflow.com/questions/17582367/angularjs-templates-cant-use-json-that-contains-hyphen
I remember why it is not preferred most languages dont have hyphen as part of valid identifier ( not java) so most often JSON is not hand rolled, there is a java class that is simply serialized using jackson and the field name becoe the JSON keys.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58172
-----------------------------------------------------------
On Oct. 23, 2014, 4:35 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 4:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Oct. 24, 2014, 12:50 a.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/JsonBean.java, line 26
> > <https://reviews.apache.org/r/27095/diff/5/?file=731692#file731692line26>
> >
> > I can see how "configs" didn't really fit for what these provide. The value associated with this key should be the resource bundles. Would "properties" or "resources" work?
> >
> > `allConfigParams` is in camel case. How about using hyphens to separate words for serialization?
>
> Veena Basavaraj wrote:
> same as above, I never seen this as a convention to use hyphens in JSON.
>
> If we seen the connector api, we have consistently used configs there, might be ok to call them just configs. But I wanted ot have all since we dont slit them by type here.
>
> Veena Basavaraj wrote:
> lots of JS libraries..have issues with hyphens in the JSON keys
>
> http://stackoverflow.com/questions/17582367/angularjs-templates-cant-use-json-that-contains-hyphen
>
> Veena Basavaraj wrote:
> I remember why it is not preferred most languages dont have hyphen as part of valid identifier ( not java) so most often JSON is not hand rolled, there is a java class that is simply serialized using jackson and the field name becoe the JSON keys.
Ah interesting. Well, can we change it later instead?
> On Oct. 24, 2014, 12:50 a.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, lines 57-58
> > <https://reviews.apache.org/r/27095/diff/5/?file=731689#file731689line57>
> >
> > Hyphenated case (if there is such a thing)?
>
> Veena Basavaraj wrote:
> sorry I did not get it. It is pretty much a practice not to use hyphens in JSON values, I have seen here the first.
Let's fix it in a follow up if that's the case?
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58172
-----------------------------------------------------------
On Oct. 24, 2014, 2:24 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 2:24 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58172
-----------------------------------------------------------
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
<https://reviews.apache.org/r/27095/#comment99136>
Hyphenated case (if there is such a thing)?
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
<https://reviews.apache.org/r/27095/#comment99105>
Shouldn't this vary by API?
For example, /connectors/ => CONNECTORS and /connectors/1/ => CONNECTOR.
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
<https://reviews.apache.org/r/27095/#comment99137>
Same as above!
common/src/main/java/org/apache/sqoop/json/JsonBean.java
<https://reviews.apache.org/r/27095/#comment99135>
I can see how "configs" didn't really fit for what these provide. The value associated with this key should be the resource bundles. Would "properties" or "resources" work?
`allConfigParams` is in camel case. How about using hyphens to separate words for serialization?
- Abraham Elmahrek
On Oct. 23, 2014, 11:35 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 11:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 23, 2014, 7:58 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, line 88
> > <https://reviews.apache.org/r/27095/diff/6/?file=731944#file731944line88>
> >
> > What about lists of connectors with exactly one connector?
then it will say connector to be precise. shuld it say connectors? if you want that then I have to refactor this out to a new class
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58228
-----------------------------------------------------------
On Oct. 23, 2014, 7:24 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 7:24 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58228
-----------------------------------------------------------
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
<https://reviews.apache.org/r/27095/#comment99185>
What about lists of connectors with exactly one connector?
common/src/main/java/org/apache/sqoop/json/JsonBean.java
<https://reviews.apache.org/r/27095/#comment99177>
ALL_CONFIGS?
common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java
<https://reviews.apache.org/r/27095/#comment99184>
These bundles aren't really Parameters in my eyes. Think "Resource" or "Properties" would work better?
- Abraham Elmahrek
On Oct. 24, 2014, 2:24 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 2:24 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 23, 2014, 9:25 p.m., Abraham Elmahrek wrote:
> > This looks good, but the integration tests are failing.
thats because the shell/client changes are not in this rb. since I split up.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58239
-----------------------------------------------------------
On Oct. 23, 2014, 8:18 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 8:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 23, 2014, 9:25 p.m., Abraham Elmahrek wrote:
> > This looks good, but the integration tests are failing.
>
> Veena Basavaraj wrote:
> thats because the shell/client changes are not in this rb. since I split up.
have fixed the client too. see patch
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58239
-----------------------------------------------------------
On Oct. 23, 2014, 8:18 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 8:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58239
-----------------------------------------------------------
Ship it!
This looks good, but the integration tests are failing.
- Abraham Elmahrek
On Oct. 24, 2014, 3:18 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 3:18 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 24, 2014, 11:10 a.m., Abraham Elmahrek wrote:
> > client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java, lines 44-46
> > <https://reviews.apache.org/r/27095/diff/10/?file=732254#file732254line44>
> >
> > ?
good catch. now I noticed my blunder.
uploaded a new one, since integration only tested for one case it did not catch it
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58303
-----------------------------------------------------------
On Oct. 24, 2014, 9:02 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java e2aae98
> client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java f6066fc
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a4dee75
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Oct. 24, 2014, 6:10 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, lines 76-84
> > <https://reviews.apache.org/r/27095/diff/6-10/?file=731944#file731944line76>
> >
> > Shouldn't these two methods be split up into 2 distinct beans? Maybe move `extractConnectors` to `extract` in ConnectorsBean?
>
> Veena Basavaraj wrote:
> i am not sure I understand? one extends the other to avoid copy paste.
>
> Veena Basavaraj wrote:
> tobe more clear, every bean should implement the extract and restore and thus the conenctors bean does it as well, it so happens that connector and connectors share the same common code so connectoss extends connector and calls the super for common logic.
>
> I hope this is more clear. OOOF!
Perfect! Didn't notice it was protected method!
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58303
-----------------------------------------------------------
On Oct. 24, 2014, 4:02 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 4:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java e2aae98
> client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java f6066fc
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a4dee75
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 24, 2014, 11:10 a.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, lines 76-84
> > <https://reviews.apache.org/r/27095/diff/6-10/?file=731944#file731944line76>
> >
> > Shouldn't these two methods be split up into 2 distinct beans? Maybe move `extractConnectors` to `extract` in ConnectorsBean?
>
> Veena Basavaraj wrote:
> i am not sure I understand? one extends the other to avoid copy paste.
tobe more clear, every bean should implement the extract and restore and thus the conenctors bean does it as well, it so happens that connector and connectors share the same common code so connectoss extends connector and calls the super for common logic.
I hope this is more clear. OOOF!
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58303
-----------------------------------------------------------
On Oct. 24, 2014, 9:02 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java e2aae98
> client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java f6066fc
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a4dee75
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Oct. 24, 2014, 11:10 a.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java, lines 76-84
> > <https://reviews.apache.org/r/27095/diff/6-10/?file=731944#file731944line76>
> >
> > Shouldn't these two methods be split up into 2 distinct beans? Maybe move `extractConnectors` to `extract` in ConnectorsBean?
i am not sure I understand? one extends the other to avoid copy paste.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58303
-----------------------------------------------------------
On Oct. 24, 2014, 9:02 a.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java e2aae98
> client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java f6066fc
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a4dee75
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58303
-----------------------------------------------------------
Almost there I think
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
<https://reviews.apache.org/r/27095/#comment99258>
Shouldn't these two methods be split up into 2 distinct beans? Maybe move `extractConnectors` to `extract` in ConnectorsBean?
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
<https://reviews.apache.org/r/27095/#comment99259>
Same thoughts as above.
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java
<https://reviews.apache.org/r/27095/#comment99256>
?
- Abraham Elmahrek
On Oct. 24, 2014, 4:02 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 4:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java e2aae98
> client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java f6066fc
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a4dee75
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/#review58352
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Oct. 24, 2014, 7:07 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27095/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 7:07 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
> https://issues.apache.org/jira/browse/SQOOP-1514
> https://issues.apache.org/jira/browse/SQOOP-1512
>
> and the parent ticket:
> https://issues.apache.org/jira/browse/SQOOP-1509
>
> It modifies the driver api and connector api.
>
> It adds a configurable api with java docs on how to use it.
> The relevant constants have been moved to their respective classes
>
> There are WS, that will be cleaned up soon
>
> Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java e2aae98
> client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java f6066fc
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a4dee75
> common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
> common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
> common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
> common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
> common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
> common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
> common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
> common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
> common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
> common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
> common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
> common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
> common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
> common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
> common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
> core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
> core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
> server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
> server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
> server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
> server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
> server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml d31120a
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
>
> Diff: https://reviews.apache.org/r/27095/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/
-----------------------------------------------------------
(Updated Oct. 24, 2014, 12:07 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see JIRA
https://issues.apache.org/jira/browse/SQOOP-1514
https://issues.apache.org/jira/browse/SQOOP-1512
and the parent ticket:
https://issues.apache.org/jira/browse/SQOOP-1509
It modifies the driver api and connector api.
It adds a configurable api with java docs on how to use it.
The relevant constants have been moved to their respective classes
There are WS, that will be cleaned up soon
Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java e2aae98
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java f6066fc
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a4dee75
common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml d31120a
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
Diff: https://reviews.apache.org/r/27095/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/
-----------------------------------------------------------
(Updated Oct. 24, 2014, 9:02 a.m.)
Review request for Sqoop.
Changes
-------
all integration tests pass ( the client has been fixed as well )
Repository: sqoop-sqoop2
Description
-------
see JIRA
https://issues.apache.org/jira/browse/SQOOP-1514
https://issues.apache.org/jira/browse/SQOOP-1512
and the parent ticket:
https://issues.apache.org/jira/browse/SQOOP-1509
It modifies the driver api and connector api.
It adds a configurable api with java docs on how to use it.
The relevant constants have been moved to their respective classes
There are WS, that will be cleaned up soon
Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java e2aae98
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java f6066fc
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java a4dee75
common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml d31120a
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
Diff: https://reviews.apache.org/r/27095/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 10:26 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see JIRA
https://issues.apache.org/jira/browse/SQOOP-1514
https://issues.apache.org/jira/browse/SQOOP-1512
and the parent ticket:
https://issues.apache.org/jira/browse/SQOOP-1509
It modifies the driver api and connector api.
It adds a configurable api with java docs on how to use it.
The relevant constants have been moved to their respective classes
There are WS, that will be cleaned up soon
Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java e2aae98
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml d31120a
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
Diff: https://reviews.apache.org/r/27095/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 8:18 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see JIRA
https://issues.apache.org/jira/browse/SQOOP-1514
https://issues.apache.org/jira/browse/SQOOP-1512
and the parent ticket:
https://issues.apache.org/jira/browse/SQOOP-1509
It modifies the driver api and connector api.
It adds a configurable api with java docs on how to use it.
The relevant constants have been moved to their respective classes
There are WS, that will be cleaned up soon
Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml d31120a
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
Diff: https://reviews.apache.org/r/27095/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 8:14 p.m.)
Review request for Sqoop.
Changes
-------
addressed
- removed params
- added a neat connectors bean class
Repository: sqoop-sqoop2
Description
-------
see JIRA
https://issues.apache.org/jira/browse/SQOOP-1514
https://issues.apache.org/jira/browse/SQOOP-1512
and the parent ticket:
https://issues.apache.org/jira/browse/SQOOP-1509
It modifies the driver api and connector api.
It adds a configurable api with java docs on how to use it.
The relevant constants have been moved to their respective classes
There are WS, that will be cleaned up soon
Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml d31120a
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
Diff: https://reviews.apache.org/r/27095/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 7:24 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see JIRA
https://issues.apache.org/jira/browse/SQOOP-1514
https://issues.apache.org/jira/browse/SQOOP-1512
and the parent ticket:
https://issues.apache.org/jira/browse/SQOOP-1509
It modifies the driver api and connector api.
It adds a configurable api with java docs on how to use it.
The relevant constants have been moved to their respective classes
There are WS, that will be cleaned up soon
Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml d31120a
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
Diff: https://reviews.apache.org/r/27095/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 4:35 p.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
see JIRA
https://issues.apache.org/jira/browse/SQOOP-1514
https://issues.apache.org/jira/browse/SQOOP-1512
and the parent ticket:
https://issues.apache.org/jira/browse/SQOOP-1509
It modifies the driver api and connector api.
It adds a configurable api with java docs on how to use it.
The relevant constants have been moved to their respective classes
There are WS, that will be cleaned up soon
Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml d31120a
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
Diff: https://reviews.apache.org/r/27095/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 4:28 p.m.)
Review request for Sqoop.
Changes
-------
addressed comments, tests pass and apis work
Repository: sqoop-sqoop2
Description
-------
see JIRA
https://issues.apache.org/jira/browse/SQOOP-1514
https://issues.apache.org/jira/browse/SQOOP-1512
and the parent ticket:
https://issues.apache.org/jira/browse/SQOOP-1509
It modifies the driver api and connector api.
It adds a configurable api with java docs on how to use it.
The relevant constants have been moved to their respective classes
There are WS, that will be cleaned up soon
Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 4372171
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 9fd2fe3
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml d31120a
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
Diff: https://reviews.apache.org/r/27095/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 1:10 p.m.)
Review request for Sqoop.
Changes
-------
fix the wrong type in the driver config. It should be JOB. hence store the type field in the config list.
Repository: sqoop-sqoop2
Description
-------
see JIRA
https://issues.apache.org/jira/browse/SQOOP-1514
https://issues.apache.org/jira/browse/SQOOP-1512
and the parent ticket:
https://issues.apache.org/jira/browse/SQOOP-1509
It modifies the driver api and connector api.
It adds a configurable api with java docs on how to use it.
The relevant constants have been moved to their respective classes
There are WS, that will be cleaned up soon
Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
common/src/main/java/org/apache/sqoop/model/MConfigList.java 8747b55
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 679859a
common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1b450d6
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 318b63c
common/src/main/java/org/apache/sqoop/model/MToConfig.java b4fbe41
common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java 9b60055
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml d31120a
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
Diff: https://reviews.apache.org/r/27095/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 27095: Sqoop-1509: Connector and Driver rest api
refactoring
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27095/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 11:09 a.m.)
Review request for Sqoop.
Changes
-------
removed WS
Repository: sqoop-sqoop2
Description (updated)
-------
see JIRA
https://issues.apache.org/jira/browse/SQOOP-1514
https://issues.apache.org/jira/browse/SQOOP-1512
and the parent ticket:
https://issues.apache.org/jira/browse/SQOOP-1509
It modifies the driver api and connector api.
It adds a configurable api with java docs on how to use it.
The relevant constants have been moved to their respective classes
There are WS, that will be cleaned up soon
Note: Sqoop Client changes to support cname will be another RB, right now it will support cid.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java bffb599
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d12b6b0
common/src/main/java/org/apache/sqoop/json/DriverBean.java 90cdbef
common/src/main/java/org/apache/sqoop/json/JobBean.java 8f42edb
common/src/main/java/org/apache/sqoop/json/JsonBean.java 8189259
common/src/main/java/org/apache/sqoop/json/LinkBean.java af0fc9d
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigParamBundleSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java cec46f6
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java f27d81d
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 1e6da6d
common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java b0a15e7
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java ac07137
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java 4f0c84d
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0369b4d
core/src/main/java/org/apache/sqoop/driver/Driver.java 6942891
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java 0d9a9b8
core/src/main/java/org/apache/sqoop/driver/DriverError.java 56ef9bb
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d7b526a
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c50e029
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9
server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0cd5acb
server/src/main/java/org/apache/sqoop/server/v1/ConfigurableServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java d24ac10
server/src/main/java/org/apache/sqoop/server/v1/ConnectorsServlet.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/v1/DriverConfigServlet.java c2b1f9f
server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java PRE-CREATION
server/src/main/webapp/WEB-INF/web.xml d31120a
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 819cf6a
Diff: https://reviews.apache.org/r/27095/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj