[GitHub] [arrow] kou commented on pull request #12228: ARROW-15410: [C++][Datasets] Improve memory usage of datasets API when scanning parquet

[GitBox <gi...@apache.org>]

kou commented on PR #12228:
URL: https://github.com/apache/arrow/pull/12228#issuecomment-1107059684

   @westonpace This breaks a GLib CI on macOS:
   
   https://github.com/apache/arrow/runs/6136118707?check_suite_focus=true#step:9:128
   
   ```text
   FAILED: arrow-glib/libarrow-glib.800.dylib.p/expression.cpp.o 
   ccache c++ -Iarrow-glib/libarrow-glib.800.dylib.p -Iarrow-glib -I../../c_glib/arrow-glib -I. -I../../c_glib -I/usr/local/include -I/usr/local/Cellar/thrift/0.16.0/include -I/usr/local/Cellar/brotli/1.0.9/include -I/usr/local/Cellar/protobuf/3.19.4/include -I/usr/local/Cellar/lz4/1.9.3/include -I/usr/local/Cellar/zstd/1.5.2/include -I/usr/local/Cellar/utf8proc/2.7.0/include -I/usr/local/Cellar/libffi/3.4.2/include -I/usr/local/Cellar/glib/2.72.1/include -I/usr/local/Cellar/glib/2.72.1/include/glib-2.0 -I/usr/local/Cellar/glib/2.72.1/lib/glib-2.0/include -I/usr/local/opt/gettext/include -I/usr/local/Cellar/pcre/8.45/include -fcolor-diagnostics -Wall -Winvalid-pch -Wnon-virtual-dtor -Werror -std=c++11 -O0 -g -Wmissing-declarations -DARROW_NO_DEPRECATED_API -DUTF8PROC_EXPORTS -MD -MQ arrow-glib/libarrow-glib.800.dylib.p/expression.cpp.o -MF arrow-glib/libarrow-glib.800.dylib.p/expression.cpp.o.d -o arrow-glib/libarrow-glib.800.dylib.p/expression.cpp.o -c ../../c_glib/arrow-glib/expres
 sion.cpp
   In file included from ../../c_glib/arrow-glib/expression.cpp:20:
   In file included from ../../c_glib/arrow-glib/compute.hpp:22:
   In file included from /usr/local/include/arrow/compute/api.h:48:
   /usr/local/include/arrow/compute/exec/options.h:202:20: error: 'arrow::compute::BackpressureControl' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
   class ARROW_EXPORT BackpressureControl {
                      ^
   1 error generated.
   ```
   
   Could you confirm this? (Is `virtual ~BackpressureControl() = default;` missing?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org