[GitHub] [incubator-baremaps] github-code-scanning[bot] commented on a diff in pull request #645: Rename Tile into TileCoord

["github-code-scanning[bot] (via GitHub)" <gi...@apache.org>]

github-code-scanning[bot] commented on code in PR #645:
URL: https://github.com/apache/incubator-baremaps/pull/645#discussion_r1186847552


##########
baremaps-core/src/main/java/org/apache/baremaps/database/tile/PostgresTileStore.java:
##########
@@ -228,17 +228,17 @@
         query.getAst().getJoins());
   }
 
-  protected String tileEnvelope(Tile tile) {
-    return String.format(TILE_ENVELOPE, tile.z(), tile.x(), tile.y());
+  protected String tileEnvelope(TileCoord tileCoord) {
+    return String.format(TILE_ENVELOPE, tileCoord.z(), tileCoord.x(), tileCoord.y());
   }
 
   /** This operation is not supported. */
-  public void write(Tile tile, ByteBuffer blob) {
+  public void write(TileCoord tileCoord, ByteBuffer blob) {
     throw new UnsupportedOperationException("The postgis tile store is read only");
   }
 
   /** This operation is not supported. */
-  public void delete(Tile tile) {
+  public void delete(TileCoord tileCoord) {

Review Comment:
   ## Missing Override annotation
   
   This method overrides [TileStore.delete](1); it is advisable to add an Override annotation.
   
   [Show more details](https://github.com/apache/incubator-baremaps/security/code-scanning/620)



##########
baremaps-core/src/test/java/org/apache/baremaps/database/tile/TileCoordIteratorTest.java:
##########
@@ -19,35 +19,35 @@
 import org.junit.jupiter.api.Test;
 import org.locationtech.jts.geom.Envelope;
 
-class TileIteratorTest {
+class TileCoordIteratorTest {

Review Comment:
   ## Unused classes and interfaces
   
   Unused class: TileCoordIteratorTest is not referenced within this codebase. If not used as an external API it should be removed.
   
   [Show more details](https://github.com/apache/incubator-baremaps/security/code-scanning/625)



##########
baremaps-core/src/main/java/org/apache/baremaps/database/tile/PostgresTileStore.java:
##########
@@ -228,17 +228,17 @@
         query.getAst().getJoins());
   }
 
-  protected String tileEnvelope(Tile tile) {
-    return String.format(TILE_ENVELOPE, tile.z(), tile.x(), tile.y());
+  protected String tileEnvelope(TileCoord tileCoord) {
+    return String.format(TILE_ENVELOPE, tileCoord.z(), tileCoord.x(), tileCoord.y());
   }
 
   /** This operation is not supported. */
-  public void write(Tile tile, ByteBuffer blob) {
+  public void write(TileCoord tileCoord, ByteBuffer blob) {

Review Comment:
   ## Missing Override annotation
   
   This method overrides [TileStore.write](1); it is advisable to add an Override annotation.
   
   [Show more details](https://github.com/apache/incubator-baremaps/security/code-scanning/621)



##########
baremaps-core/src/test/java/org/apache/baremaps/database/tile/TileCoordTest.java:
##########
@@ -17,23 +17,23 @@
 import org.junit.jupiter.api.Test;
 import org.locationtech.jts.geom.Envelope;
 
-class TileTest {
+class TileCoordTest {

Review Comment:
   ## Unused classes and interfaces
   
   Unused class: TileCoordTest is not referenced within this codebase. If not used as an external API it should be removed.
   
   [Show more details](https://github.com/apache/incubator-baremaps/security/code-scanning/623)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org