You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by paul-rogers <gi...@git.apache.org> on 2017/03/26 01:27:56 UTC
[GitHub] drill pull request #799: DRILL-5234: External sort spill fails for maps
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/799
DRILL-5234: External sort spill fails for maps
External sort's spilling functionality does not work when the spilled
columns contains a map type column.
The problem occurs only when assertions are on and is due to an
incorrect assumption used to verify that data is read correctly. The
original code used capacity as the number of bytes actually read, but
this is a poor choice; capacity reflects power-of-two rounding having
nothing to do with serialized data.
Changed to use the writerIndex instead which should be positioned past
the last byte written to the vector during deserialization.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-rogers/drill DRILL-5234
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/799.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #799
----
commit 5427470ecdc8ff2815022fa2214717012e514832
Author: Paul Rogers <pr...@maprtech.com>
Date: 2017-03-26T01:27:40Z
DRILL-5234: External sort spill fails for maps
External sort's spilling functionality does not work when the spilled
columns contains a map type column.
The problem occurs only when assertions are on and is due to an
incorrect assumption used to verify that data is read correctly. The
original code used capacity as the number of bytes actually read, but
this is a poor choice; capacity reflects power-of-two rounding having
nothing to do with serialized data.
Changed to use the writerIndex instead which should be positioned past
the last byte written to the vector during deserialization.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #799: DRILL-5234: External sort spill fails for maps
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/799
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---