[GitHub] [orc] kbendick edited a comment on pull request #769: Bump jmh.version from 1.20 to 1.32 in /java

[GitBox <gi...@apache.org>]

kbendick edited a comment on pull request #769:
URL: https://github.com/apache/orc/pull/769#issuecomment-886418788


   > In this PR, we are clearly see `jmh` 1.20 to 1.32 is breaking because there are big gap. We have two options
   > 
   > 1. Pin the version
   > 2. Make an official JIRA for this upgrade.
   > 
   > cc @wgtmac , @pgaref , @williamhyun
   
   In the Apache Iceberg repo, we [pin JMH to version 1.21](https://github.com/apache/iceberg/blob/0b53e70d813f6acfb3198567781d3b3ef921d6d8/build.gradle#L118), which is very close to the existing 1.20.
   
   I have been somewhat taking care of the JMH tests over there / have most recently worked on them.
   
   For us, the upgrade is a larger deal because we use a [specific JMH gradle plugin](https://github.com/melix/jmh-gradle-plugin) which would require a newer version of gradle to upgrade to. I would personally recommend pinning the version in the short term, and then making a JIRA for upgrading.
   
   As I've become somewhat more familiar with JMH testing from working with the Iceberg JMH tests, I'd be happy to take the JIRA for upgrading JMH to 1.32 assuming we don't use any plugins which would involve a much larger refactor (I don't think we do). 🙂 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org