[jira] [Commented] (RATIS-34) Use ConfUtils to get and set RaftServerConfigKeys

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893523#comment-15893523 ] 

Tsz Wo Nicholas Sze commented on RATIS-34:
------------------------------------------

Below is a list of all the keys in RaftServerConfigKeys:
{code}
******* interface org.apache.ratis.server.RaftServerConfigKeys *******
PREFIX = raft.server
KB = 1024
MB = 1048576
raft.server.storage.dir (String, default=file:///tmp/raft-server/)
raft.server.staging.catchup.gap (int, default=1000)
  
  ******* interface org.apache.ratis.server.RaftServerConfigKeys$Rpc *******
  PREFIX = raft.server.rpc
  raft.server.rpc.timeout.min.ms (int, default=150)
  raft.server.rpc.timeout.max.ms (int, default=300)
  raft.server.rpc.sleep.time.ms (int, default=25)
  
  ******* interface org.apache.ratis.server.RaftServerConfigKeys$Snapshot *******
  PREFIX = raft.server.snapshot
  raft.server.snapshot.auto.trigger.enabled (boolean, default=false)
  raft.server.snapshot.auto.trigger.threshold (long, default=400000)
  
  ******* interface org.apache.ratis.server.RaftServerConfigKeys$Log *******
  PREFIX = raft.server.log
  raft.server.log.use.memory (boolean, default=false)
  raft.server.log.segment.size.max (long, default=8388608)
  raft.server.log.preallocated.size (int, default=4194304)
  raft.server.log.write.buffer.size (int, default=65536)
  raft.server.log.force.sync.num (int, default=128)
    
    ******* interface org.apache.ratis.server.RaftServerConfigKeys$Log$Appender *******
    PREFIX = raft.server.log.appender
    raft.server.log.appender.buffer.capacity (int, default=4194304)
    raft.server.log.appender.batch.enabled (boolean, default=false)
    raft.server.log.appender.snapshot.chunk.size.max (int, default=16777216)
{code}


> Use ConfUtils to get and set RaftServerConfigKeys
> -------------------------------------------------
>
>                 Key: RATIS-34
>                 URL: https://issues.apache.org/jira/browse/RATIS-34
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: r34_20170302.patch
>
>
> The methods in ConfUtils make the code shorter, easier to read and less error prone.  We should use them to get and set RaftServerConfigKeys



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)