You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/08 23:41:01 UTC
[GitHub] [airflow] dstandish opened a new pull request #19484: KubernetesExecutor should default to template image if used
dstandish opened a new pull request #19484:
URL: https://github.com/apache/airflow/pull/19484
Currently, the user must specify image and tag in airflow.cfg, even when they are using a pod template file. If the pod template file specifies an image and tag, the user should not be forced to also specify this in airflow.cfg.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a change in pull request #19484: KubernetesExecutor should default to template image if used
Posted by GitBox <gi...@apache.org>.
dstandish commented on a change in pull request #19484:
URL: https://github.com/apache/airflow/pull/19484#discussion_r745178143
##########
File path: airflow/kubernetes/kube_config.py
##########
@@ -45,7 +45,10 @@ def __init__(self):
self.worker_container_repository = conf.get(self.kubernetes_section, 'worker_container_repository')
self.worker_container_tag = conf.get(self.kubernetes_section, 'worker_container_tag')
- self.kube_image = f'{self.worker_container_repository}:{self.worker_container_tag}'
+ if self.worker_container_repository and self.worker_container_tag:
Review comment:
we could probably loosen this to allow user to specify image only (and not tag) but this is the current behavior. currently if either is not specified it won't work unless specified in executor_config
##########
File path: tests/kubernetes/test_pod_generator.py
##########
@@ -38,8 +38,8 @@
from airflow.kubernetes.secret import Secret
-class TestPodGenerator(unittest.TestCase):
- def setUp(self):
Review comment:
converting to pytest is required when combining pytest params and unittest.mock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #19484: KubernetesExecutor should default to template image if used
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #19484:
URL: https://github.com/apache/airflow/pull/19484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #19484: KubernetesExecutor should default to template image if used
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #19484:
URL: https://github.com/apache/airflow/pull/19484#issuecomment-963851991
looks like the one failure is unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19484: KubernetesExecutor should default to template image if used
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19484:
URL: https://github.com/apache/airflow/pull/19484#issuecomment-963685929
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org