You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "charlesbluca (via GitHub)" <gi...@apache.org> on 2024/05/15 13:23:34 UTC
[I] Bump maturin version to satisfy conda-forge constraints? [datafusion-python]
charlesbluca opened a new issue, #701:
URL: https://github.com/apache/datafusion-python/issues/701
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
Availability of this package on conda-forge for each Python minor version is dependent on there being an associated `maturin` package built against that minor version - in the case of python 3.12, there are no builds of `maturin` that satisfy `>=0.15,<0.16`, blocking the ability to publish packages for 3.12 (https://github.com/conda-forge/datafusion-feedstock/pull/44#discussion_r1599045665).
**Describe the solution you'd like**
Bumping the `maturin` version constraints to something that contains at least 1.2.3 would give us access to 3.12 builds, allowing conda-forge packages of this project to be published for python 3.12.
**Additional context**
Discussion around this is surrounding https://github.com/conda-forge/datafusion-feedstock/pull/44.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Bump maturin version to satisfy conda-forge constraints? [datafusion-python]
Posted by "charlesbluca (via GitHub)" <gi...@apache.org>.
charlesbluca commented on issue #701:
URL: https://github.com/apache/datafusion-python/issues/701#issuecomment-2163408725
> Does conda-forge pull from main? Or do we need a new release to test if that fix solves the issue?
conda-forge pulls the sdist for a versioned release from PyPI, but I don't actually think the maturin constraint contained in this code forces us to that maturin version; for example, in https://github.com/conda-forge/datafusion-feedstock/pull/44, we are rebuilding using the 34.0.0 source code, which constrains `maturin>=0.15,<0.16`, we are still able to pull a newer maturin version and build successfully with it.
In short, I think we should be safe to move to the updated constraint in #725 to unblock some of the older conda-forge that have been blocked:
- https://github.com/conda-forge/datafusion-feedstock/pull/43
- https://github.com/conda-forge/datafusion-feedstock/pull/44
- https://github.com/conda-forge/datafusion-feedstock/pull/45
- https://github.com/conda-forge/datafusion-feedstock/pull/46
- https://github.com/conda-forge/datafusion-feedstock/pull/47
- https://github.com/conda-forge/datafusion-feedstock/pull/48
And then continue using this updated constraint for future conda-forge builds moving forward.
As a side note, not sure if you're interested in being a maintainer of the linked feedstock? This would give you write access to the repo as well as notifications of these past build attempts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Bump maturin version to satisfy conda-forge constraints? [datafusion-python]
Posted by "Michael-J-Ward (via GitHub)" <gi...@apache.org>.
Michael-J-Ward commented on issue #701:
URL: https://github.com/apache/datafusion-python/issues/701#issuecomment-2158469610
#725 is merged and upgrades maturin on `main`.
Does `conda-forge` pull from `main`? Or do we need a new release to test if that fix solves the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Bump maturin version to satisfy conda-forge constraints? [datafusion-python]
Posted by "Michael-J-Ward (via GitHub)" <gi...@apache.org>.
Michael-J-Ward commented on issue #701:
URL: https://github.com/apache/datafusion-python/issues/701#issuecomment-2176694042
I don't have a good mental model for `conda` and its ecosystem, but I just started watching the feedstock repo so maybe I'll learn a little.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Bump maturin version to satisfy conda-forge constraints? [datafusion-python]
Posted by "Michael-J-Ward (via GitHub)" <gi...@apache.org>.
Michael-J-Ward commented on issue #701:
URL: https://github.com/apache/datafusion-python/issues/701#issuecomment-2368785873
Resolved by #725.
The final arch migrator appears to be something different. https://github.com/conda-forge/datafusion-feedstock/pull/46#issuecomment-2368602285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Bump maturin version to satisfy conda-forge constraints? [datafusion-python]
Posted by "Michael-J-Ward (via GitHub)" <gi...@apache.org>.
Michael-J-Ward closed issue #701: Bump maturin version to satisfy conda-forge constraints?
URL: https://github.com/apache/datafusion-python/issues/701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org