You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org> on 2006/09/21 22:37:24 UTC
[jira] Updated: (TOMAHAWK-50) equals validator shows text (nit nice
by validating passwords...)
[ http://issues.apache.org/jira/browse/TOMAHAWK-50?page=all ]
Martin Marinschek updated TOMAHAWK-50:
--------------------------------------
Status: Resolved (was: Patch Available)
Fix Version/s: 1.1.4-SNAPSHOT
Resolution: Fixed
Assignee: Martin Marinschek (was: Matthias Weßendorf)
Mike had already something close to this to tomahawk. I've been trying to do a merge where it made sense, e.g. I find the addition of a summaryMessage attribute definitely useful, also the resolving of the FacesMessage is somehow handled better.
What I've seen throughout the validator code - the value-bindings are never set as value-bindings, but always as pure string-values. Is that really what we want to do?
regards,
Martin
> equals validator shows text (nit nice by validating passwords...)
> -----------------------------------------------------------------
>
> Key: TOMAHAWK-50
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-50
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Validators
> Reporter: Matthias Weßendorf
> Assigned To: Martin Marinschek
> Fix For: 1.1.4-SNAPSHOT
>
> Attachments: myfaces-991.zip
>
>
> <dave>
> I am using t:validateEqual for password. when two passwords are not equal, the passwords(clear) show up on client browser in validation error message. Would it be nice if there is a flag to hide the passard on server side?
> </dave>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Updated: (TOMAHAWK-50) equals validator shows text (nit nice by validating passwords...)
Posted by Mike Kienenberger <mk...@gmail.com>.
The only issues I see keeping validateCompareTo in the sandbox are localization.
On 9/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
> I also think this entire equalsTo component needs to become a subclass
> of validateCompareTo with some of the attributes hardcoded.
>
Re: [jira] Updated: (TOMAHAWK-50) equals validator shows text (nit nice by validating passwords...)
Posted by Mike Kienenberger <mk...@gmail.com>.
On 9/21/06, Martin Marinschek (JIRA) <de...@myfaces.apache.org> wrote:
> [ http://issues.apache.org/jira/browse/TOMAHAWK-50?page=all ]
>
> Martin Marinschek updated TOMAHAWK-50:
> --------------------------------------
>
> Status: Resolved (was: Patch Available)
> Fix Version/s: 1.1.4-SNAPSHOT
> Resolution: Fixed
> Assignee: Martin Marinschek (was: Matthias Weßendorf)
>
> Mike had already something close to this to tomahawk. I've been trying to do a merge where it made sense, e.g. I find the addition of a summaryMessage attribute definitely useful, also the resolving of the FacesMessage is somehow handled better.
>
> What I've seen throughout the validator code - the value-bindings are never set as value-bindings, but always as pure string-values. Is that really what we want to do?
Sure. I think we should update ValidatorBase to support
summaryMessage and detailMessage as well as message.
I also think this entire equalsTo component needs to become a subclass
of validateCompareTo with some of the attributes hardcoded.