You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "codelipenghui (via GitHub)" <gi...@apache.org> on 2023/03/07 05:39:50 UTC
[GitHub] [bookkeeper] codelipenghui opened a new pull request, #3844: Fix memory leak issue of reading small entries
codelipenghui opened a new pull request, #3844:
URL: https://github.com/apache/bookkeeper/pull/3844
### Motivation
Fix the memory leak issue of reading small entries.
It will not impact the existing releases. But it should be a blocker for the 4.16.0 release
It was introduced by https://github.com/apache/bookkeeper/pull/3597
### Changes
Release the original buffer after copied the data into a single buffer (header + payload)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat merged pull request #3844: Fix memory leak issue of reading small entries
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #3844:
URL: https://github.com/apache/bookkeeper/pull/3844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3844: Fix memory leak issue of reading small entries
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3844:
URL: https://github.com/apache/bookkeeper/pull/3844#issuecomment-1457606024
# [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3844](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (745b688) into [master](https://codecov.io/gh/apache/bookkeeper/commit/1bd1745742ce920a6bc015e086b78cc1aaec6357?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1bd1745) will **increase** coverage by `7.21%`.
> The diff coverage is `12.50%`.
```diff
@@ Coverage Diff @@
## master #3844 +/- ##
============================================
+ Coverage 32.58% 39.79% +7.21%
- Complexity 3113 3939 +826
============================================
Files 473 473
Lines 40910 40961 +51
Branches 5232 5240 +8
============================================
+ Hits 13329 16301 +2972
+ Misses 25919 22903 -3016
- Partials 1662 1757 +95
```
| Flag | Coverage Δ | |
|---|---|---|
| bookie | `39.79% <12.50%> (?)` | |
| remaining | `?` | |
| tls | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/bookkeeper/replication/ReplicationWorker.java](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcmVwbGljYXRpb24vUmVwbGljYXRpb25Xb3JrZXIuamF2YQ==) | `0.00% <0.00%> (-75.41%)` | :arrow_down: |
| [...g/apache/bookkeeper/proto/BookieProtoEncoding.java](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vQm9va2llUHJvdG9FbmNvZGluZy5qYXZh) | `59.68% <100.00%> (-15.42%)` | :arrow_down: |
| [...ain/java/org/apache/bookkeeper/auth/AuthToken.java](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYXV0aC9BdXRoVG9rZW4uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/bookkeeper/meta/UnderreplicatedLedger.java](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9VbmRlcnJlcGxpY2F0ZWRMZWRnZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...bookkeeper/meta/LedgerUnderreplicationManager.java](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9MZWRnZXJVbmRlcnJlcGxpY2F0aW9uTWFuYWdlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...apache/bookkeeper/tls/FileModifiedTimeUpdater.java](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvdGxzL0ZpbGVNb2RpZmllZFRpbWVVcGRhdGVyLmphdmE=) | `0.00% <0.00%> (-94.45%)` | :arrow_down: |
| [...a/org/apache/bookkeeper/client/LedgerFragment.java](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0xlZGdlckZyYWdtZW50LmphdmE=) | `0.00% <0.00%> (-90.79%)` | :arrow_down: |
| [...org/apache/bookkeeper/replication/AuditorTask.java](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcmVwbGljYXRpb24vQXVkaXRvclRhc2suamF2YQ==) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [.../java/org/apache/bookkeeper/util/SubTreeCache.java](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvdXRpbC9TdWJUcmVlQ2FjaGUuamF2YQ==) | `15.00% <0.00%> (-85.00%)` | :arrow_down: |
| [...rg/apache/bookkeeper/replication/AuditorStats.java](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcmVwbGljYXRpb24vQXVkaXRvclN0YXRzLmphdmE=) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| ... and [258 more](https://codecov.io/gh/apache/bookkeeper/pull/3844?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org