[GitHub] [drill-site] vdiravka commented on a change in pull request #8: DRILL-7996: Documentation for OCI OS Storage Plugin

[GitBox <gi...@apache.org>]

vdiravka commented on a change in pull request #8:
URL: https://github.com/apache/drill-site/pull/8#discussion_r702547614



##########
File path: _docs/en/connect-a-data-source/plugins/110-s3-storage-plugin.md
##########
@@ -14,7 +14,7 @@ To connect Drill to S3:
 
 For additional information, refer to the [HDFS S3 documentation](https://hadoop.apache.org/docs/stable/hadoop-aws/tools/hadoop-aws/index.html).   
 
-**Note:** Drill does not use HDFS 3.x, therefore Drill does not support AWS temporary credentials, as described in the s3a documentation.
+**Note:** Drill started using HDFS 3.0, but support of AWS temporary credentials (as described in the s3a documentation) wasn't verified yet.

Review comment:
       This about AWS temporary creds, not Drill temporary creds.
   
   I just found outdated info, the doc was written before Drill supports hadoop3.0.
   But now Drill leverages `3.2.2` hadoop version. And it supports `TemporaryAWSCredentialsProvider` 
   ```
   <property>
     <name>fs.s3a.session.token</name>
     <description>
       Session token, when using org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider
       as one of the providers.
     </description>
   </property>
   ```
   https://hadoop.apache.org/docs/stable/hadoop-aws/tools/hadoop-aws/index.html
   Therefore  it can be used in Drill.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org