You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by "D.J. Heap" <dj...@shadyvale.net> on 2003/09/26 03:55:59 UTC

[PATCH] Tests

Any objections to committing this?

I ran it through all tests (local, svn, dav) on RH9 and WinXP again 
yesterday with no failures on Linux and the expected two per protocol on 
Windows.  The 'svn commit -F A\B\C' failure I should be able to supply a 
patch for tomorrow or Saturday.  The commit-22 failure I'm still 
investigating, but it's not new -- it's been failing on and off for me 
for months.

Log:

Change the test suite to expect local path separators instead of 
tweaking the results to always have '/' separators; Subversion is now 
using and outputting local path separators almost everywhere and some of 
the tests were breaking on Windows.  Most of this patch is removing 
tweak-results-on-Windows code.

* subversion/tests/clients/cmdline/copy_tests.py
* subversion/tests/clients/cmdline/basic_tests.py
* subversion/tests/clients/cmdline/trans_tests.py
* subversion/tests/clients/cmdline/schedule_tests.py
* subversion/tests/clients/cmdline/merge_tests.py
   Remove tweaks and distinguish between local paths and urls.

* subversion/tests/clients/cmdline/svntest/actions.py
   After building the test url by appending a local path,
   change '\' to '/' if we're on Windows.


* subversion/tests/clients/cmdline/svnlook_tests.py
* subversion/tests/clients/cmdline/diff_tests.py
   Diffs are one place where we still use '/' all
   the time, so it needs a slight tweak if running on Windows.
   This tweak should be removed when/if diffs are changed to use
   local separators.

* subversion/tests/clients/cmdline/svntest/main.py
   Build the test paths using local path separators and make sure
   urls always use '/'.

Re: [PATCH] Tests

Posted by Branko Čibej <br...@xbc.nu>.

D.J. Heap wrote:

> Branko Čibej wrote:
> [snip]
>
>> Could you also take the time to submit an issue about the need to review
>> the libraries and insert calls to
>> svn_path_local_style/svn_path_internal_style wherever they're still
>> missing? Thanks.
>
>
> Issue 1538 has been entered.

Thank you!

> [snip]
>
>>
>> Please user string.replace instead -- that is,
>>
>>     name = string.replace(name, '\\', '/')
>>
>> IIRC this will keep the tests compatible with Python 2.0. Greg, please
>> correct me if I'm wrong.
>>
>
> Ok, there are a few other occurrences in tree.py, should I fix those
> as well?  (There's also some in gen_win.py; I can patch those
> separately if desired)

I think that would be good, yes.


-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Tests

Posted by Branko Čibej <br...@xbc.nu>.

D.J. Heap wrote:

> Updated and re-tested.
>
> Log:
>
> Change the test suite to expect local path separators instead of
> tweaking the results to always have '/' separators; Subversion is now
> using and outputting local path separators almost everywhere and some of
> the tests were breaking on Windows. Most of this patch is removing
> tweak-results-on-Windows code.

Wonderful. Go ahead and commit this. And thanks for taking the time!

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Tests

Posted by "D.J. Heap" <dj...@shadyvale.net>.

Updated and re-tested.

Log:

Change the test suite to expect local path separators instead of
tweaking the results to always have '/' separators; Subversion is now
using and outputting local path separators almost everywhere and some of
the tests were breaking on Windows. Most of this patch is removing
tweak-results-on-Windows code.

* subversion/tests/clients/cmdline/copy_tests.py
* subversion/tests/clients/cmdline/basic_tests.py
* subversion/tests/clients/cmdline/trans_tests.py
* subversion/tests/clients/cmdline/schedule_tests.py
* subversion/tests/clients/cmdline/merge_tests.py
   Remove tweaks and distinguish between local paths and urls.

* subversion/tests/clients/cmdline/svntest/actions.py
   After building the test url by appending a local path,
   change '\' to '/' if we're on Windows.

* subversion/tests/clients/cmdline/svnlook_tests.py
* subversion/tests/clients/cmdline/diff_tests.py
   Diffs are one place where we still use '/' all
   the time, so it needs a slight tweak if running on Windows.
   This tweak should be removed when/if diffs are changed to use
   local separators.

* subversion/tests/clients/cmdline/svntest/main.py
   Build the test paths using local path separators and make sure
   urls always use '/'.

* subversion/tests/clients/cmdline/svntest/tree.py
   For Python 2.0 compatibility, change var.replace calls to
   string.replace calls.

Re: [PATCH] Tests

Posted by "D.J. Heap" <dj...@shadyvale.net>.

Branko Čibej wrote:
[snip]
> Could you also take the time to submit an issue about the need to review
> the libraries and insert calls to
> svn_path_local_style/svn_path_internal_style wherever they're still
> missing? Thanks.

Issue 1538 has been entered.

[snip]
> 
> Please user string.replace instead -- that is,
> 
>     name = string.replace(name, '\\', '/')
> 
> IIRC this will keep the tests compatible with Python 2.0. Greg, please
> correct me if I'm wrong.
> 

Ok, there are a few other occurrences in tree.py, should I fix those as 
well?  (There's also some in gen_win.py; I can patch those separately if 
desired)

DJ


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Tests

Posted by Branko Čibej <br...@xbc.nu>.

D.J. Heap wrote:

> Any objections to committing this?

+1, except for one tweak, see below.

Could you also take the time to submit an issue about the need to review
the libraries and insert calls to
svn_path_local_style/svn_path_internal_style wherever they're still
missing? Thanks.

[snip]

>+# On Windows, diffs still display / rather than \ in paths
>+  if svntest.main.windows == 1:
>+    name = name.replace('\\', '/')
>  
>
Please user string.replace instead -- that is,

    name = string.replace(name, '\\', '/')

IIRC this will keep the tests compatible with Python 2.0. Greg, please
correct me if I'm wrong.

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org