You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@plc4x.apache.org by "Christofer Dutz (Jira)" <ji...@apache.org> on 2021/07/28 21:00:00 UTC
[jira] [Commented] (PLC4X-307) Permit customized package names for
code generation
[ https://issues.apache.org/jira/browse/PLC4X-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389066#comment-17389066 ]
Christofer Dutz commented on PLC4X-307:
---------------------------------------
This should also be quite a low-hanging-fruit for newcomers.
In each language module, we have the so-called LanguageHelper Java classes. These usually have a method called:
packageName (For Java) or
fileName (For Go)
As far as I can see it, you need to add a config option to the maven plugin and to pass along this option to the construction of the language helper. It shouldn't be too complicated.
> Permit customized package names for code generation
> ---------------------------------------------------
>
> Key: PLC4X-307
> URL: https://issues.apache.org/jira/browse/PLC4X-307
> Project: Apache PLC4X
> Issue Type: New Feature
> Components: Code-Generation
> Affects Versions: 0.9.0
> Reporter: Łukasz Dywicki
> Priority: Major
>
> Currently code generation assumes static naming convention. For example Java templates always put generated code in {{org.apache.plc4x.<language=java>,<protocol>,<flavor=readwrite>}}, where protocol is defined via SPI provider.
> This assumption works fine for our own drivers, however it also leads to several assumptions in other places. For example a test framework does silently assume that types used for serialization/deserialization are always in above.
> While use can customize language templates or "helper" SPI he can not easily adjust ser/deser test framework internals. A better handling of user defined packages might promote wider use of tools developed by project.
> Currently issue is mainly specific to Java (not sure about Go). Other languages and their test frameworks might require adjustments as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)