You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@river.apache.org by Sim IJskes - QCG <si...@qcg.nl> on 2010/11/25 16:40:00 UTC
Re: svn commit: r1039074 - /incubator/river/jtsk/trunk/qa/build.xml
On 25-11-10 16:34, thobbs@apache.org wrote:
> URL: http://svn.apache.org/viewvc?rev=1039074&view=rev Log: Stopped
> river.home from being overriden so that the correct java-savy path
> can be used from the ../build.properties file. This helps more jtreg
> tests pass (on Windows), specifically those that use the HTTPD
> class.
I believe you have tried to fix something that is caused by the
inheritAll=false in the ant call. I did not want to change that, so if
you want to inherit a property, you can do the same as the
harness.generateHtml property
<target name="qa.run" depends="" description="Run QA tests">
<!-- Call qa subcomponent build -->
<ant dir="qa" target="run" inheritall="false">
<property name="harness.generateHtml"
value="${harness.generateHtml}" />
</ant>
</target>
Gr. Sim
--
QCG, Software voor het MKB, 071-5890970, http://www.qcg.nl
Quality Consultancy Group b.v., Leiderdorp, Kvk Den Haag: 28088397
Re: svn commit: r1039074 - /incubator/river/jtsk/trunk/qa/build.xml
Posted by Sim IJskes - QCG <si...@qcg.nl>.
On 25-11-10 16:47, Tom Hobbs wrote:
> I'm not sure how this helps because river.home was set to some value
> before the common.xml was loaded.
>
> I'm happy for the property to be inherited - and it is (now). The
> problem was it was getting set before the inheritance happened and
> thus it's value was not getting overwritten by the act of inheriting
> common.xml.
Perfect. You can indeed take it out as you did. Its defined in
common.xml anyhow, so it was a duplicate.
But your comment is much more interesting. That means we are too early
making it a 'location' property. I guess its used in httpd as url?
Gr. Sim
--
QCG, Software voor het MKB, 071-5890970, http://www.qcg.nl
Quality Consultancy Group b.v., Leiderdorp, Kvk Den Haag: 28088397
Re: svn commit: r1039074 - /incubator/river/jtsk/trunk/qa/build.xml
Posted by Tom Hobbs <tv...@googlemail.com>.
I'm not sure how this helps because river.home was set to some value
before the common.xml was loaded.
I'm happy for the property to be inherited - and it is (now). The
problem was it was getting set before the inheritance happened and
thus it's value was not getting overwritten by the act of inheriting
common.xml.
What would you suggest? I'm not an Ant magician, I just know enough
to muddle through.
The change is specifically for the jtreg tests. (e.g. "ant jtreg")
On Thu, Nov 25, 2010 at 3:40 PM, Sim IJskes - QCG <si...@qcg.nl> wrote:
> On 25-11-10 16:34, thobbs@apache.org wrote:
>>
>> URL: http://svn.apache.org/viewvc?rev=1039074&view=rev Log: Stopped
>> river.home from being overriden so that the correct java-savy path
>> can be used from the ../build.properties file. This helps more jtreg
>> tests pass (on Windows), specifically those that use the HTTPD
>> class.
>
> I believe you have tried to fix something that is caused by the
> inheritAll=false in the ant call. I did not want to change that, so if you
> want to inherit a property, you can do the same as the harness.generateHtml
> property
>
> <target name="qa.run" depends="" description="Run QA tests">
> <!-- Call qa subcomponent build -->
> <ant dir="qa" target="run" inheritall="false">
> <property name="harness.generateHtml" value="${harness.generateHtml}" />
> </ant>
> </target>
>
> Gr. Sim
>
>
> --
> QCG, Software voor het MKB, 071-5890970, http://www.qcg.nl
> Quality Consultancy Group b.v., Leiderdorp, Kvk Den Haag: 28088397
>