[GitHub] [zookeeper] anmolnar commented on issue #1143: ZOOKEEPER-3598. Fix trunk build

[GitBox <gi...@apache.org>]

anmolnar commented on issue #1143: ZOOKEEPER-3598. Fix trunk build
URL: https://github.com/apache/zookeeper/pull/1143#issuecomment-554111519
 
 
   @eolivelli Adding some more context, because I think you misunderstood my fix.
   
   The problem with the original code is that while the thread is waiting for CommitProcessor thread to finish in `this.wait(millis)`, it will be interrupted by somebody else (JUnit runner?). 
   The code cathes the interrupted exception properly and pass on to test if CommitProcessor is still running with `this.isAlive()`.
   There's some chance here that CP is still running and System.exit() will be called shutting down the entire process.
   
   My fix changes the original behavior to avoid further processing by quiting the entire shutdown method if calling thread has been interrupted. This significantly changes the original implementation, hence we need to look very carefully.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services