You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by jo...@apache.org on 2011/06/28 15:46:16 UTC

svn commit: r1140613 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java

Author: joshcanfield
Date: Tue Jun 28 13:46:16 2011
New Revision: 1140613

URL: http://svn.apache.org/viewvc?rev=1140613&view=rev
Log:
TAP5-1559 - Excessive warnings

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java?rev=1140613&r1=1140612&r2=1140613&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java Tue Jun 28 13:46:16 2011
@@ -14,10 +14,6 @@
 
 package org.apache.tapestry5.services;
 
-import org.apache.tapestry5.plastic.MethodAdvice;
-import org.apache.tapestry5.plastic.PlasticClass;
-import org.apache.tapestry5.plastic.PlasticMethod;
-
 /**
  * An object that receives control around an "advised" method of a component. The advise can query or even replace
  * method parameters. After invoking {@link org.apache.tapestry5.services.ComponentMethodInvocation#proceed()}, the
@@ -26,8 +22,11 @@ import org.apache.tapestry5.plastic.Plas
  * @see TransformMethod#addAdvice(ComponentMethodAdvice)
  * @see ComponentInstanceOperation
  * @deprecated Deprecated in 5.3
- * @see {@link PlasticClass}, {@link PlasticMethod}, {@link MethodAdvice}
+ * @see org.apache.tapestry5.plastic.PlasticClass
+ * @see org.apache.tapestry5.plastic.PlasticMethod
+ * @see org.apache.tapestry5.plastic.MethodAdvice
  */
+@SuppressWarnings({"deprecation"})
 public interface ComponentMethodAdvice
 {
     void advise(ComponentMethodInvocation invocation);

Re: svn commit: r1140613 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java

Posted by Ulrich Stärk <ul...@spielviel.de>.
Ah ok then. I didn't have a look at the source itself just saw the diff.

On 29.06.2011 16:46, Josh Canfield wrote:
> Also a deprecated class using deprecated methods/classes
> On Jun 29, 2011 2:12 AM, "Ulrich Stärk" <ul...@spielviel.de> wrote:
>> Same here: I think deprecation warnings shouldn't be suppressed. Either
> fix them or keep them.
>> On 28.06.2011 15:46, joshcanfield@apache.org wrote:
>>> Author: joshcanfield
>>> Date: Tue Jun 28 13:46:16 2011
>>> New Revision: 1140613
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1140613&view=rev
>>> Log:
>>> TAP5-1559 - Excessive warnings
>>>
>>> Modified:
>>>
> tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java
>>> Modified:
> tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java
>>> URL:
> http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java?rev=1140613&r1=1140612&r2=1140613&view=diff
> ==============================================================================
>>> ---
> tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java
> (original)
>>> +++
> tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java
> Tue Jun 28 13:46:16 2011
>>> @@ -14,10 +14,6 @@
>>>
>>> package org.apache.tapestry5.services;
>>>
>>> -import org.apache.tapestry5.plastic.MethodAdvice;
>>> -import org.apache.tapestry5.plastic.PlasticClass;
>>> -import org.apache.tapestry5.plastic.PlasticMethod;
>>> -
>>> /**
>>> * An object that receives control around an "advised" method of a
> component. The advise can query or even replace
>>> * method parameters. After invoking {@link
> org.apache.tapestry5.services.ComponentMethodInvocation#proceed()}, the
>>> @@ -26,8 +22,11 @@ import org.apache.tapestry5.plastic.Plas
>>> * @see TransformMethod#addAdvice(ComponentMethodAdvice)
>>> * @see ComponentInstanceOperation
>>> * @deprecated Deprecated in 5.3
>>> - * @see {@link PlasticClass}, {@link PlasticMethod}, {@link
> MethodAdvice}
>>> + * @see org.apache.tapestry5.plastic.PlasticClass
>>> + * @see org.apache.tapestry5.plastic.PlasticMethod
>>> + * @see org.apache.tapestry5.plastic.MethodAdvice
>>> */
>>> +@SuppressWarnings({"deprecation"})
>>> public interface ComponentMethodAdvice
>>> {
>>> void advise(ComponentMethodInvocation invocation);
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: svn commit: r1140613 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java

Posted by Josh Canfield <jo...@gmail.com>.
Also a deprecated class using deprecated methods/classes
On Jun 29, 2011 2:12 AM, "Ulrich Stärk" <ul...@spielviel.de> wrote:
> Same here: I think deprecation warnings shouldn't be suppressed. Either
fix them or keep them.
>
> On 28.06.2011 15:46, joshcanfield@apache.org wrote:
>> Author: joshcanfield
>> Date: Tue Jun 28 13:46:16 2011
>> New Revision: 1140613
>>
>> URL: http://svn.apache.org/viewvc?rev=1140613&view=rev
>> Log:
>> TAP5-1559 - Excessive warnings
>>
>> Modified:
>>
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java
>>
>> Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java
>> URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java?rev=1140613&r1=1140612&r2=1140613&view=diff
>>
==============================================================================
>> ---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java
(original)
>> +++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java
Tue Jun 28 13:46:16 2011
>> @@ -14,10 +14,6 @@
>>
>> package org.apache.tapestry5.services;
>>
>> -import org.apache.tapestry5.plastic.MethodAdvice;
>> -import org.apache.tapestry5.plastic.PlasticClass;
>> -import org.apache.tapestry5.plastic.PlasticMethod;
>> -
>> /**
>> * An object that receives control around an "advised" method of a
component. The advise can query or even replace
>> * method parameters. After invoking {@link
org.apache.tapestry5.services.ComponentMethodInvocation#proceed()}, the
>> @@ -26,8 +22,11 @@ import org.apache.tapestry5.plastic.Plas
>> * @see TransformMethod#addAdvice(ComponentMethodAdvice)
>> * @see ComponentInstanceOperation
>> * @deprecated Deprecated in 5.3
>> - * @see {@link PlasticClass}, {@link PlasticMethod}, {@link
MethodAdvice}
>> + * @see org.apache.tapestry5.plastic.PlasticClass
>> + * @see org.apache.tapestry5.plastic.PlasticMethod
>> + * @see org.apache.tapestry5.plastic.MethodAdvice
>> */
>> +@SuppressWarnings({"deprecation"})
>> public interface ComponentMethodAdvice
>> {
>> void advise(ComponentMethodInvocation invocation);
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>

Re: svn commit: r1140613 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java

Posted by Ulrich Stärk <ul...@spielviel.de>.
Same here: I think deprecation warnings shouldn't be suppressed. Either fix them or keep them.

On 28.06.2011 15:46, joshcanfield@apache.org wrote:
> Author: joshcanfield
> Date: Tue Jun 28 13:46:16 2011
> New Revision: 1140613
>
> URL: http://svn.apache.org/viewvc?rev=1140613&view=rev
> Log:
> TAP5-1559 - Excessive warnings
>
> Modified:
>     tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java
>
> Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java
> URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java?rev=1140613&r1=1140612&r2=1140613&view=diff
> ==============================================================================
> --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java (original)
> +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ComponentMethodAdvice.java Tue Jun 28 13:46:16 2011
> @@ -14,10 +14,6 @@
>  
>  package org.apache.tapestry5.services;
>  
> -import org.apache.tapestry5.plastic.MethodAdvice;
> -import org.apache.tapestry5.plastic.PlasticClass;
> -import org.apache.tapestry5.plastic.PlasticMethod;
> -
>  /**
>   * An object that receives control around an "advised" method of a component. The advise can query or even replace
>   * method parameters. After invoking {@link org.apache.tapestry5.services.ComponentMethodInvocation#proceed()}, the
> @@ -26,8 +22,11 @@ import org.apache.tapestry5.plastic.Plas
>   * @see TransformMethod#addAdvice(ComponentMethodAdvice)
>   * @see ComponentInstanceOperation
>   * @deprecated Deprecated in 5.3
> - * @see {@link PlasticClass}, {@link PlasticMethod}, {@link MethodAdvice}
> + * @see org.apache.tapestry5.plastic.PlasticClass
> + * @see org.apache.tapestry5.plastic.PlasticMethod
> + * @see org.apache.tapestry5.plastic.MethodAdvice
>   */
> +@SuppressWarnings({"deprecation"})
>  public interface ComponentMethodAdvice
>  {
>      void advise(ComponentMethodInvocation invocation);
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org