You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2015/08/10 11:27:48 UTC
Review Request 37288: [FALCON-1384] AbstractEntityHelper.java cleanup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37288/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1384
https://issues.apache.org/jira/browse/FALCON-1384
Repository: falcon-git
Description
-------
As of now the class has many fields with different access levels(privated, protected, public etc). We want have a uniform pattern to the extent possible.
Also, the file is a jumble of variables and methods - can we reorganize to make it more readable.
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 2baa35f
falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java 7157111
Diff: https://reviews.apache.org/r/37288/diff/
Testing
-------
ran FeedResumeTest as test
Thanks,
Paul Isaychuk
Re: Review Request 37288: [FALCON-1384] AbstractEntityHelper.java
cleanup
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37288/#review94754
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On Aug. 10, 2015, 2:27 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37288/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 2:27 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1384
> https://issues.apache.org/jira/browse/FALCON-1384
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> As of now the class has many fields with different access levels(privated, protected, public etc). We want have a uniform pattern to the extent possible.
> Also, the file is a jumble of variables and methods - can we reorganize to make it more readable.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 2baa35f
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java 7157111
>
> Diff: https://reviews.apache.org/r/37288/diff/
>
>
> Testing
> -------
>
> ran FeedResumeTest as test
>
>
> Thanks,
>
> Paul Isaychuk
>
>