[GitHub] [ozone] ChenSammi commented on a diff in pull request #3918: HDDS-7441. Rename function names of retrieving metadata keys

[GitBox <gi...@apache.org>]

ChenSammi commented on code in PR #3918:
URL: https://github.com/apache/ozone/pull/3918#discussion_r1067777603


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java:
##########
@@ -402,10 +403,10 @@ private void markBlocksForDeletionSchemaV1(
       try (BatchOperation batch = containerDB.getStore().getBatchHandler()
           .initBatchOperation()) {
         for (Long blkLong : delTX.getLocalIDList()) {
-          String blk = containerData.blockKey(blkLong);
+          String blk = containerData.getBlockMetaKey(blkLong);

Review Comment:
   Hi @symious , thanks for improving the readability of the code.  
   I would recommend to use getBlockKey instead of getBlockMetaKey here since the function will return the key's value.  Meta is a word that different people may have different understandings. It will cause confusing. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org