You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/12/04 20:38:22 UTC

[kudu-CR] messenger: stop using deprecated mem fun 

Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14834


Change subject: messenger: stop using deprecated mem_fun
......................................................................

messenger: stop using deprecated mem_fun

When building against LLVM 9's libc++, we get a warning about using a
deprecated function. Seems like mem_fn is the appropriate replacement.

../../src/kudu/rpc/messenger.cc:238:48: warning: 'mem_fun<void, kudu::rpc::Messenger>' is deprecated [-Wdeprecated-declarations]
  *msgr = shared_ptr<Messenger>(new_msgr, std::mem_fun(&Messenger::AllExternalReferencesDropped));
                                               ^
../../thirdparty/installed/tsan/include/c++/v1/functional:1148:1: note: 'mem_fun<void, kudu::rpc::Messenger>' has been explicitly marked deprecated here
_LIBCPP_DEPRECATED_IN_CXX11 inline _LIBCPP_INLINE_VISIBILITY
^
../../thirdparty/installed/tsan/include/c++/v1/__config:944:39: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX11'
                                      ^
../../thirdparty/installed/tsan/include/c++/v1/__config:933:48: note: expanded from macro '_LIBCPP_DEPRECATED'
                                               ^
1 warning generated.

Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
2 files changed, 8 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/14834/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
Gerrit-Change-Number: 14834
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>

[kudu-CR] messenger: stop using deprecated mem fun

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14834

to look at the new patch set (#2).

Change subject: messenger: stop using deprecated mem_fun
......................................................................

messenger: stop using deprecated mem_fun

When building against LLVM 9's libc++, we get a warning about using a
deprecated function. Seems like mem_fn is the appropriate replacement.

../../src/kudu/rpc/messenger.cc:238:48: warning: 'mem_fun<void, kudu::rpc::Messenger>' is deprecated [-Wdeprecated-declarations]
  *msgr = shared_ptr<Messenger>(new_msgr, std::mem_fun(&Messenger::AllExternalReferencesDropped));
                                               ^
../../thirdparty/installed/tsan/include/c++/v1/functional:1148:1: note: 'mem_fun<void, kudu::rpc::Messenger>' has been explicitly marked deprecated here
_LIBCPP_DEPRECATED_IN_CXX11 inline _LIBCPP_INLINE_VISIBILITY
^
../../thirdparty/installed/tsan/include/c++/v1/__config:944:39: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX11'
                                      ^
../../thirdparty/installed/tsan/include/c++/v1/__config:933:48: note: expanded from macro '_LIBCPP_DEPRECATED'
                                               ^
1 warning generated.

Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
2 files changed, 11 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/14834/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
Gerrit-Change-Number: 14834
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] messenger: stop using deprecated mem fun

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14834 )

Change subject: messenger: stop using deprecated mem_fun
......................................................................

messenger: stop using deprecated mem_fun

When building against LLVM 9's libc++, we get a warning about using a
deprecated function. Seems like mem_fn is the appropriate replacement.

../../src/kudu/rpc/messenger.cc:238:48: warning: 'mem_fun<void, kudu::rpc::Messenger>' is deprecated [-Wdeprecated-declarations]
  *msgr = shared_ptr<Messenger>(new_msgr, std::mem_fun(&Messenger::AllExternalReferencesDropped));
                                               ^
../../thirdparty/installed/tsan/include/c++/v1/functional:1148:1: note: 'mem_fun<void, kudu::rpc::Messenger>' has been explicitly marked deprecated here
_LIBCPP_DEPRECATED_IN_CXX11 inline _LIBCPP_INLINE_VISIBILITY
^
../../thirdparty/installed/tsan/include/c++/v1/__config:944:39: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX11'
                                      ^
../../thirdparty/installed/tsan/include/c++/v1/__config:933:48: note: expanded from macro '_LIBCPP_DEPRECATED'
                                               ^
1 warning generated.

Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
Reviewed-on: http://gerrit.cloudera.org:8080/14834
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
2 files changed, 11 insertions(+), 13 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Grant Henke: Looks good to me, approved
  Adar Dembo: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
Gerrit-Change-Number: 14834
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] messenger: stop using deprecated mem fun

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14834

to look at the new patch set (#4).

Change subject: messenger: stop using deprecated mem_fun
......................................................................

messenger: stop using deprecated mem_fun

When building against LLVM 9's libc++, we get a warning about using a
deprecated function. Seems like mem_fn is the appropriate replacement.

../../src/kudu/rpc/messenger.cc:238:48: warning: 'mem_fun<void, kudu::rpc::Messenger>' is deprecated [-Wdeprecated-declarations]
  *msgr = shared_ptr<Messenger>(new_msgr, std::mem_fun(&Messenger::AllExternalReferencesDropped));
                                               ^
../../thirdparty/installed/tsan/include/c++/v1/functional:1148:1: note: 'mem_fun<void, kudu::rpc::Messenger>' has been explicitly marked deprecated here
_LIBCPP_DEPRECATED_IN_CXX11 inline _LIBCPP_INLINE_VISIBILITY
^
../../thirdparty/installed/tsan/include/c++/v1/__config:944:39: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX11'
                                      ^
../../thirdparty/installed/tsan/include/c++/v1/__config:933:48: note: expanded from macro '_LIBCPP_DEPRECATED'
                                               ^
1 warning generated.

Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
2 files changed, 11 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/14834/4
-- 
To view, visit http://gerrit.cloudera.org:8080/14834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
Gerrit-Change-Number: 14834
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] messenger: stop using deprecated mem fun

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14834 )

Change subject: messenger: stop using deprecated mem_fun
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
Gerrit-Change-Number: 14834
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Dec 2019 14:24:57 +0000
Gerrit-HasComments: No

[kudu-CR] messenger: stop using deprecated mem fun

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14834 )

Change subject: messenger: stop using deprecated mem_fun
......................................................................


Patch Set 4: Verified+1

Overriding Jenkins, unrelated known test flake.


-- 
To view, visit http://gerrit.cloudera.org:8080/14834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
Gerrit-Change-Number: 14834
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Dec 2019 18:55:26 +0000
Gerrit-HasComments: No

[kudu-CR] messenger: stop using deprecated mem fun

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14834 )

Change subject: messenger: stop using deprecated mem_fun
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
Gerrit-Change-Number: 14834
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Dec 2019 06:07:30 +0000
Gerrit-HasComments: No

[kudu-CR] messenger: stop using deprecated mem fun

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/14834 )

Change subject: messenger: stop using deprecated mem_fun
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/14834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ife57c52050ba19a07218694c84989fa16f1dd341
Gerrit-Change-Number: 14834
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>