Re: [PR] [SPARK-47475][CORE]: Jars Download to Driver to Follow `spark.kubernetes.jars.avoidDownloadSchemes` under K8s Cluster Mode [spark]

["leletan (via GitHub)" <gi...@apache.org>]

leletan commented on code in PR #45715:
URL: https://github.com/apache/spark/pull/45715#discussion_r1538651802


##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:
##########
@@ -401,16 +401,24 @@ private[spark] class SparkSubmit extends Logging {
         // SPARK-33782 : This downloads all the files , jars , archiveFiles and pyfiles to current
         // working directory
         // SPARK-43540: add current working directory into driver classpath
+        // SPARK-47475: make download to driver optional so executors may fetch resource from remote
+        // url directly to avoid overwhelming driver network when resource is big and executor count
+        // is high
         val workingDirectory = "."
         childClasspath += workingDirectory
-        def downloadResourcesToCurrentDirectory(uris: String, isArchive: Boolean = false):
+
+        def downloadResourcesToCurrentDirectory(uris: String,
+                                                isArchive: Boolean = false,

Review Comment:
   Thanks for the tips, @dongjoon-hyun. Ran ` ./dev/scalafmt` as mentioned, it actually modified a lot of existing code style as well (not relevant to this PR) - is this expected? Or there is something I missed here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org