You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2010/04/28 09:46:32 UTC
[jira] Created: (SLING-1508) Default auth handlers are not
considered if a handler has a protocol or host
Default auth handlers are not considered if a handler has a protocol or host
----------------------------------------------------------------------------
Key: SLING-1508
URL: https://issues.apache.org/jira/browse/SLING-1508
Project: Sling
Issue Type: Bug
Components: Commons
Affects Versions: Commons Auth 1.0.0
Reporter: Carsten Ziegeler
Fix For: Commons Auth 1.0.0
The PathBasedHolderCache builds a map of maps for auth handlers. The first map is by protocol, the second map by host.
If now a auth handler has a protocol and/or a host, the created list does not contain the default/fallback authhandlers (which don't have a protocol and host set).
So as soon as one handler has a protocol/host, default handlers are not considered anymore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1508) Default auth handlers are not
considered if a handler has a protocol or host
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-1508.
-------------------------------------
Assignee: Carsten Ziegeler
Resolution: Fixed
I've committed a different version than the patch: instead of merging the maps during an update of the auth handlers, a fixed array of possible candidates is returned and this array is queried.
I've replaced the hard synchronization with a read write lock as well
> Default auth handlers are not considered if a handler has a protocol or host
> ----------------------------------------------------------------------------
>
> Key: SLING-1508
> URL: https://issues.apache.org/jira/browse/SLING-1508
> Project: Sling
> Issue Type: Bug
> Components: Commons
> Affects Versions: Commons Auth 1.0.0
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING1508
>
>
> The PathBasedHolderCache builds a map of maps for auth handlers. The first map is by protocol, the second map by host.
> If now a auth handler has a protocol and/or a host, the created list does not contain the default/fallback authhandlers (which don't have a protocol and host set).
> So as soon as one handler has a protocol/host, default handlers are not considered anymore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1508) Default auth handlers are not
considered if a handler has a protocol or host
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated SLING-1508:
------------------------------------
Attachment: SLING1508
Potential patch
> Default auth handlers are not considered if a handler has a protocol or host
> ----------------------------------------------------------------------------
>
> Key: SLING-1508
> URL: https://issues.apache.org/jira/browse/SLING-1508
> Project: Sling
> Issue Type: Bug
> Components: Commons
> Affects Versions: Commons Auth 1.0.0
> Reporter: Carsten Ziegeler
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING1508
>
>
> The PathBasedHolderCache builds a map of maps for auth handlers. The first map is by protocol, the second map by host.
> If now a auth handler has a protocol and/or a host, the created list does not contain the default/fallback authhandlers (which don't have a protocol and host set).
> So as soon as one handler has a protocol/host, default handlers are not considered anymore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1508) Default auth handlers are not
considered if a handler has a protocol or host
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed SLING-1508.
------------------------------------
Close after release
> Default auth handlers are not considered if a handler has a protocol or host
> ----------------------------------------------------------------------------
>
> Key: SLING-1508
> URL: https://issues.apache.org/jira/browse/SLING-1508
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.0
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: Auth Core 1.0.0
>
> Attachments: SLING1508
>
>
> The PathBasedHolderCache builds a map of maps for auth handlers. The first map is by protocol, the second map by host.
> If now a auth handler has a protocol and/or a host, the created list does not contain the default/fallback authhandlers (which don't have a protocol and host set).
> So as soon as one handler has a protocol/host, default handlers are not considered anymore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1508) Default auth handlers are not
considered if a handler has a protocol or host
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863841#action_12863841 ]
Carsten Ziegeler commented on SLING-1508:
-----------------------------------------
I've provided a potential patch which is based on the old SlingAuthenticator code from the engine - the benefit (if it works correctly....) is that with the
patch there is no synchronization anymore when accessing the holders.
The patch looks wilder than it is, as I changed the return types to use the List interface instead of the ArrayList implementation....
> Default auth handlers are not considered if a handler has a protocol or host
> ----------------------------------------------------------------------------
>
> Key: SLING-1508
> URL: https://issues.apache.org/jira/browse/SLING-1508
> Project: Sling
> Issue Type: Bug
> Components: Commons
> Affects Versions: Commons Auth 1.0.0
> Reporter: Carsten Ziegeler
> Fix For: Commons Auth 1.0.0
>
> Attachments: SLING1508
>
>
> The PathBasedHolderCache builds a map of maps for auth handlers. The first map is by protocol, the second map by host.
> If now a auth handler has a protocol and/or a host, the created list does not contain the default/fallback authhandlers (which don't have a protocol and host set).
> So as soon as one handler has a protocol/host, default handlers are not considered anymore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1508) Default auth handlers are not
considered if a handler has a protocol or host
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1508:
-------------------------------------
Component/s: Authentication
(was: Commons)
> Default auth handlers are not considered if a handler has a protocol or host
> ----------------------------------------------------------------------------
>
> Key: SLING-1508
> URL: https://issues.apache.org/jira/browse/SLING-1508
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.0
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: Auth Core 1.0.0
>
> Attachments: SLING1508
>
>
> The PathBasedHolderCache builds a map of maps for auth handlers. The first map is by protocol, the second map by host.
> If now a auth handler has a protocol and/or a host, the created list does not contain the default/fallback authhandlers (which don't have a protocol and host set).
> So as soon as one handler has a protocol/host, default handlers are not considered anymore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.