You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/03/18 10:04:31 UTC
Review Request 32196: SQOOP-2227: SQOOP2: Clear connector cache in
ShowConnectorFunction.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32196/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
The root cause of avoiding connector cache is this case:
When a user without privilege of READ CONNECTOR runs a "show connector" in CLI, the result page shows nothing.
Then this user is granted READ CONNECTOR privilege. But he could not show all connector immediately, due to connector cache, unless he restart the Sqoop Client.
Diffs
-----
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2a21b85abd2aa6b37cbd3f791c583f7179049ba8
Diff: https://reviews.apache.org/r/32196/diff/
Testing
-------
manual
Thanks,
richard zhou
Re: Review Request 32196: SQOOP-2227: SQOOP2: Clear connector cache in
ShowConnectorFunction.java
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32196/#review76993
-----------------------------------------------------------
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java
<https://reviews.apache.org/r/32196/#comment124746>
I think it will be a bit slower, but it's fine. Another option is to clear the cache when ever the GRANT or REVOKE commands are run. Would that be ok?
- Abraham Elmahrek
On March 18, 2015, 9:04 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32196/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 9:04 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> The root cause of avoiding connector cache is this case:
> When a user without privilege of READ CONNECTOR runs a "show connector" in CLI, the result page shows nothing.
> Then this user is granted READ CONNECTOR privilege. But he could not show all connector immediately, due to connector cache, unless he restart the Sqoop Client.
>
>
> Diffs
> -----
>
> shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2a21b85abd2aa6b37cbd3f791c583f7179049ba8
>
> Diff: https://reviews.apache.org/r/32196/diff/
>
>
> Testing
> -------
>
> manual
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 32196: SQOOP-2227: SQOOP2: Clear connector cache in
ShowConnectorFunction.java
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32196/#review77443
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On March 23, 2015, 8:58 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32196/
> -----------------------------------------------------------
>
> (Updated March 23, 2015, 8:58 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> The root cause of avoiding connector cache is this case:
> When a user without privilege of READ CONNECTOR runs a "show connector" in CLI, the result page shows nothing.
> Then this user is granted READ CONNECTOR privilege. But he could not show all connector immediately, due to connector cache, unless he restart the Sqoop Client.
>
>
> Diffs
> -----
>
> shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java ccf898844b88d11cc710584d748dc794c3b6b525
> shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java e0b86cf067c0c27301c4dbefd2a5ca99eab428c3
>
> Diff: https://reviews.apache.org/r/32196/diff/
>
>
> Testing
> -------
>
> manual
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 32196: SQOOP-2227: SQOOP2: Clear connector cache in
ShowConnectorFunction.java
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32196/
-----------------------------------------------------------
(Updated March 23, 2015, 8:58 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
The root cause of avoiding connector cache is this case:
When a user without privilege of READ CONNECTOR runs a "show connector" in CLI, the result page shows nothing.
Then this user is granted READ CONNECTOR privilege. But he could not show all connector immediately, due to connector cache, unless he restart the Sqoop Client.
Diffs (updated)
-----
shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java ccf898844b88d11cc710584d748dc794c3b6b525
shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java e0b86cf067c0c27301c4dbefd2a5ca99eab428c3
Diff: https://reviews.apache.org/r/32196/diff/
Testing
-------
manual
Thanks,
richard zhou