[kudu] 03/05: Reduce "Overwriting operations" log spam on bootstrap

[gr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch branch-1.9.x
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 5f096744f7fc0e12871f52a3d632251967a72c32
Author: Will Berkeley <wd...@gmail.org>
AuthorDate: Thu Feb 14 17:13:09 2019 -0800

    Reduce "Overwriting operations" log spam on bootstrap
    
    While messing around on a cluster, I noticed that when bootstrapping
    tablets it would absolutely spew messages like the following:
    
    I0214 17:18:28.358758 13664 tablet_bootstrap.cc:910] T 97537c2af52940f48f06d32ecfdde2a2 P 09d6bf7a02124145b43f43cb7a667b3d: Overwriting operations starting at: 283482.180847 up to 283482.180847 with operation: 283483.180847
    
    This is an expected outcome when a leader or follower has uncommitted
    operations that get rolled back because of updates from a new leader in
    a later term. There's nothing unusual or noteworthy about it. So, let's
    not bother logging at INFO. I lowered the level to VLOG(1) in case
    someone finds a need to see it in the future.
    
    Change-Id: I965f5950d2076c7a1147b943003b5e5df9a2246b
    Reviewed-on: http://gerrit.cloudera.org:8080/12492
    Tested-by: Kudu Jenkins
    Reviewed-by: Andrew Wong <aw...@cloudera.com>
    Reviewed-by: Alexey Serbin <as...@cloudera.com>
    (cherry picked from commit 812955ee0983a5b0dfba2d50529f8972c25bf411)
    Reviewed-on: http://gerrit.cloudera.org:8080/12508
---
 src/kudu/tablet/tablet_bootstrap.cc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/kudu/tablet/tablet_bootstrap.cc b/src/kudu/tablet/tablet_bootstrap.cc
index 084b1e0..e62549e 100644
--- a/src/kudu/tablet/tablet_bootstrap.cc
+++ b/src/kudu/tablet/tablet_bootstrap.cc
@@ -907,10 +907,10 @@ Status TabletBootstrap::HandleReplicateMessage(ReplayState* state,
     DCHECK(OpIdEquals(iter->second->replicate().id(), existing_entry->replicate().id()));
 
     const auto& last_entry = state->pending_replicates.rbegin()->second;
-    LOG_WITH_PREFIX(INFO) << "Overwriting operations starting at: "
-                          << existing_entry->replicate().id()
-                          << " up to: " << last_entry->replicate().id()
-                          << " with operation: " << replicate.id();
+    VLOG_WITH_PREFIX(1) << "Overwriting operations starting at: "
+                        << existing_entry->replicate().id()
+                        << " up to: " << last_entry->replicate().id()
+                        << " with operation: " << replicate.id();
 
     while (iter != state->pending_replicates.end()) {
       iter = state->pending_replicates.erase(iter);