You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:19:30 UTC
[GitHub] [solr] thelabdude opened a new pull request #181: SOLR-15456: Get field type info from luke for custom fields instead of defaulting to String
thelabdude opened a new pull request #181:
URL: https://github.com/apache/solr/pull/181
https://issues.apache.org/jira/browse/SOLR-15456
# Description
See JIRA
# Solution
Added additional request to get schema info from luke for custom field types. Added short-term cache for holding schema information for a table to reduce lookups to luke.
# Tests
Added unit test to verify the type information for custom fields resolves correctly.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #181: SOLR-15456: Get field type info from luke for custom fields instead of defaulting to String
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #181:
URL: https://github.com/apache/solr/pull/181#issuecomment-863548812
Still thinking about the caching of schema info here ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude merged pull request #181: SOLR-15456: Get field type info from luke for custom fields instead of defaulting to String
Posted by GitBox <gi...@apache.org>.
thelabdude merged pull request #181:
URL: https://github.com/apache/solr/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude merged pull request #181: SOLR-15456: Get field type info from luke for custom fields instead of defaulting to String
Posted by GitBox <gi...@apache.org>.
thelabdude merged pull request #181:
URL: https://github.com/apache/solr/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #181: SOLR-15456: Get field type info from luke for custom fields instead of defaulting to String
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #181:
URL: https://github.com/apache/solr/pull/181#issuecomment-865195272
@markrmiller I decided to remove the Cache for luke responses from this PR for now. I like your idea about pushing cache support into the LukeRequestHandler, but think that should be tackled in a separate PR. For this PR, I'm not all that convinced caching would even buy us much given requests to the `/sql` handler would be load-balanced, so unlikely to see enough cache hits to justify the added code complexity of ensuring the cached field / field type info isn't stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #181: SOLR-15456: Get field type info from luke for custom fields instead of defaulting to String
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #181:
URL: https://github.com/apache/solr/pull/181#issuecomment-865195272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #181: SOLR-15456: Get field type info from luke for custom fields instead of defaulting to String
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #181:
URL: https://github.com/apache/solr/pull/181#issuecomment-865196735
> I think this conflicts with #177 can you and Mark chat about the proper implementation of `toSolrLiteral`/`translateTerms`
@markrmiller I think this PR will get merged before your upgrade ... once you merge in my changes here, you can drop the `translateTerms` call and just use my changes as I switched to calling `getValue2()` as you're doing in your PR ... thanks for catching this @madrob ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #181: SOLR-15456: Get field type info from luke for custom fields instead of defaulting to String
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #181:
URL: https://github.com/apache/solr/pull/181#issuecomment-863742745
I think this conflicts with #177 can you and Mark chat about the proper implementation of `toSolrLiteral`/`translateTerms`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org