You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "garydgregory (via GitHub)" <gi...@apache.org> on 2023/07/02 14:43:00 UTC

[GitHub] [commons-lang] garydgregory commented on pull request #1069: LANG-1647

garydgregory commented on PR #1069:
URL: https://github.com/apache/commons-lang/pull/1069#issuecomment-1616686083

   -1 as is, in https://issues.apache.org/jira/browse/LANG-1647 the description reads:
   ```
   The idea it's have a function that check if a given throwable is a checked exception. There are some similar function in ConcurrentUtils, but have package visibility and return the same exception. 
   
   Seem logic have this verification in the class that have this responsibility - ExceptionUtils
   ```
   `ConcurrentUtils` and anywhere else in Commons Lang should reuse these new APIs, otherwise, the PR just creates duplication of existing code patterns.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org